After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592368 - Missing string after format string in camel-mapi-folder.c
Missing string after format string in camel-mapi-folder.c
Status: RESOLVED FIXED
Product: evolution-mapi
Classification: Applications
Component: miscellaneous
unspecified
Other Linux
: Normal normal
: 0.30
Assigned To: evolution-mapi-maint
evolution-mapi-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-19 18:44 UTC by Claude Paroz
Modified: 2009-09-08 06:15 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Claude Paroz 2009-08-19 18:44:44 UTC
While searching for the meaning of %s in "Offline. '%s'", I found that there was no %s string in the function call:

if (offline->state == CAMEL_OFFLINE_STORE_NETWORK_UNAVAIL) {
	camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM, 
			      _("Offline. '%s'"));
	return;

Isn't this an error?
Comment 1 Johnny Jacob 2009-08-28 04:15:51 UTC
Removed %s in master. Closing as fixed.
Comment 2 Akhil Laddha 2009-08-31 09:56:44 UTC
I did revert changes as it breaks string freeze 

http://git.gnome.org/cgit/evolution-mapi/commit/?id=f11ab592830b2be944875c9c719fc14ca94095e5
Comment 3 Claude Paroz 2009-08-31 10:03:34 UTC
Fine. Is this something critical, in a programmatical point of view?
If not, then you should simply wait that the module has branched for gnome-2-28 before pushing it to master again.
Comment 4 Johnny Jacob 2009-09-08 06:15:52 UTC
(In reply to comment #3)
> Fine. Is this something critical, in a programmatical point of view?

Not really.

> If not, then you should simply wait that the module has branched for gnome-2-28
> before pushing it to master again.

Just branched now and pushed the patches. Closing this report as fixed.

Thanks.