GNOME Bugzilla – Bug 592279
Introspection support
Last modified: 2009-12-20 03:08:14 UTC
This is a *work in progress* series of patches. Attaching here for initial review comments, and so the work doesn't get lost.
Created attachment 141123 [details] [review] [introspection] Build introspection data for gdk-pixbuf, gdk, and gtk Generate .gir and .typelib files for gdk-pixbuf, gdk, and gtk.
Created attachment 141124 [details] [review] [introspection] Merge in Gdk-custom.c introspection annotations The Gdk-custom.c file in gir-repository contained a number of introspection annotations. Merge those into the GDK source files. Some documentation was moved from the tmpl/ files to accomodate the addition of annotations.
Created attachment 141125 [details] [review] [introspection] Merge in Gtk-custom.c annotations The Gtk-custom.c file in gir-repository contained a number of introspection annotations. Merge those into the GTK source files. Some documentation was moved from the tmpl/ files to accomodate the addition of annotations.
*** Bug 568613 has been marked as a duplicate of this bug. ***
Created attachment 141194 [details] [review] [introspection] Build introspection data for gdk-pixbuf, gdk, and gtk Generate .gir and .typelib files for gdk-pixbuf, gdk, and gtk.
Created attachment 141195 [details] [review] [introspection] Merge in Gdk-custom.c introspection annotations The Gdk-custom.c file in gir-repository contained a number of introspection annotations. Merge those into the GDK source files. Some documentation was moved from the tmpl/ files to accomodate the addition of annotations.
Created attachment 141196 [details] [review] [introspection] Merge in Gtk-custom.c annotations The Gtk-custom.c file in gir-repository contained a number of introspection annotations. Merge those into the GTK source files. Some documentation was moved from the tmpl/ files to accomodate the addition of annotations.
These updated patches add the -enumtypes.c files to the scans, fix up some trailing whitespace, and add a few more annotations.
Without looking in too much detail, these patches look generally fine to me. Do we need to bump GTK_DOC_CHECK([1.11]) to require a gtk-doc that is new enough to handle these annotations ?
gtk-doc 1.11 is not enough: we'll need a 1.12 release at some point, otherwise gtk-doc will spew out a lot of warnings and the docs will look very odd (unfortunately, it's the current situation with Clutter).
Created attachment 147457 [details] [review] Merge in Gtk-custom.c annotations The Gtk-custom.c file in gir-repository contained a number of introspection annotations. Merge those into the GTK source files. Some documentation was moved from the tmpl/ files to accomodate the addition of annotations.
Created attachment 147459 [details] [review] Add a couple of annotations to collection arguments
Have rebased walter's gtk commit and added a couple more of annotations.
These patches pick up some private symbols because of internal .h files that get sucked into the scan. Eg, $(gdk_c_sources) includes gdkinternals.h, gdkpoly-generic.h and gdkregion-generic.h
I create a new introspection branch and: - Applied the patches from Colin and Tomeu - Made sure the scanner isn't parsing private headers as Dan pointed out - Added introspection.m4 to the source to avoid needing that when distchecking I had to fix a bug in gobject-introspection, so it depend on HEAD of that.
This got pushed to master, thanks!
this is great, except make gtk-update-icon-cache Makefile:2669: no file name for `include' and line 2669 in Makefile is include $(INTROSPECTION_MAKEFILE) and the build dies
whoops, this seems to be related to commit ff1343a594383e0d88b1aecdf34025dd3ee36ed6 and i only noticed introspection near the scene of the crime sorry