After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592146 - Build introspection data if available and configured
Build introspection data if available and configured
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: general
1.28.x
Other All
: Normal normal
: ---
Assigned To: Li Yuan
Li Yuan
: 568612 (view as bug list)
Depends on:
Blocks: 585444 592279
 
 
Reported: 2009-08-17 21:40 UTC by Colin Walters
Modified: 2010-03-02 07:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Build introspection data if available and configured (1.99 KB, patch)
2009-08-17 21:40 UTC, Colin Walters 		none Details | Review
Add introspection support (4.48 KB, patch)
2009-12-09 18:02 UTC, Johan (not receiving bugmail) Dahlin 		none Details | Review
Add introspection support (4.48 KB, patch)
2009-12-10 10:31 UTC, Johan (not receiving bugmail) Dahlin 		committed Details | Review
Build introspection data if available and configured (2.04 KB, patch)
2009-12-10 10:31 UTC, Johan (not receiving bugmail) Dahlin 		committed Details | Review

Description Colin Walters 2009-08-17 21:40:17 UTC 
Add --enable-introspection option via the GOBJECT_INTROSPECTION_CHECK
macro, and implement the build rules.
Comment 1 Colin Walters 2009-08-17 21:40:19 UTC 
Created attachment 140998 [details] [review]
Build introspection data if available and configured
Comment 2 Colin Walters 2009-08-19 00:47:57 UTC 
*** Bug 568612 has been marked as a duplicate of this bug. ***
Comment 3 Matthias Clasen 2009-12-02 17:23:50 UTC 
Can we get this in ? the .gir situation is causing me some jhbuild heartburn...
Comment 4 Li Yuan 2009-12-03 03:22:19 UTC 
I see build errors if I don't have gobject-introspection installed on my system. GOBJECT_INTROSPECTION_CHECK is only defined in introspection.m4 which is shipped by gobject-introspection.

So maybe we should check if there is gobject-introspection package installed first?
Comment 5 Johan (not receiving bugmail) Dahlin 2009-12-09 17:55:48 UTC 
Li: We can just include the .m4 file in the atk+ tarball, would that be okay?
Comment 6 Johan (not receiving bugmail) Dahlin 2009-12-09 18:02:56 UTC 
Created attachment 149467 [details] [review]
Add introspection support

Updated patch for HEAD which also adds an m4 directory with the
macro so the package maintainer doesn't need to install gobject-introspection
to distcheck atk
Comment 7 Li Yuan 2009-12-10 07:13:44 UTC 
I am OK with it. But why the first patch is obsoleted?
Comment 8 Johan (not receiving bugmail) Dahlin 2009-12-10 10:31:22 UTC 
Li, it's obsoleted because it's superseeded by the second patch.
Comment 9 Johan (not receiving bugmail) Dahlin 2009-12-10 10:31:40 UTC 
The following fixes have been pushed:
392d9be Add introspection support
c7d9898 Build introspection data if available and configured
Comment 10 Johan (not receiving bugmail) Dahlin 2009-12-10 10:31:46 UTC 
Created attachment 149507 [details] [review]
Add introspection support
Comment 11 Johan (not receiving bugmail) Dahlin 2009-12-10 10:31:51 UTC 
Created attachment 149508 [details] [review]
Build introspection data if available and configured

Add --enable-introspection option via the GOBJECT_INTROSPECTION_CHECK
macro, and implement the build rules.