After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592006 - Untranslatable string construction in gdu-drive.c
Untranslatable string construction in gdu-drive.c
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-16 21:04 UTC by Claude Paroz
Modified: 2009-08-18 20:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Claude Paroz 2009-08-16 21:04:13 UTC 
In gdu-drive.c, the below code is flawed regarding i18n. E.g. in French, the order of words are inverted (Lecteur Flash). How can I properly translate this?

/* If we know the media type, just append Drive */
if (result->len > 0) {
    g_string_append_c (result, ' ');
    /* Translators: This word is appended after the media type, e.g. 'CD/DVD Drive' or
     * 'CompactFlash Drive'
     */
    g_string_append (result, C_("Media Type", "Drive"));

The fix should probably be something that call g_strdup_printf (_("%s Drive"), result). Please if possible fix before string freeze.
Comment 1 David Zeuthen (not reading bugmail) 2009-08-18 20:14:21 UTC 
(In reply to comment #0)
> In gdu-drive.c, the below code is flawed regarding i18n. E.g. in French, the
> order of words are inverted (Lecteur Flash). How can I properly translate this?
> 
> /* If we know the media type, just append Drive */
> if (result->len > 0) {
>     g_string_append_c (result, ' ');
>     /* Translators: This word is appended after the media type, e.g. 'CD/DVD
> Drive' or
>      * 'CompactFlash Drive'
>      */
>     g_string_append (result, C_("Media Type", "Drive"));
> 
> The fix should probably be something that call g_strdup_printf (_("%s Drive"),
> result). Please if possible fix before string freeze.

Good point. Fixed with this commit:

http://git.gnome.org/cgit/gnome-disk-utility/commit/?id=34fe2c9a790dc5c01f2c5e7429e7fd61cb1ef4e6

Thanks for noticing.
Comment 2 Claude Paroz 2009-08-18 20:29:17 UTC 
Thanks, that's so much better now!