After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591969 - make the FileChooser dialog handle Make FileChooser handle G_IO_ERROR_FILENAME_TOO_LONG errors
make the FileChooser dialog handle Make FileChooser handle G_IO_ERROR_FILENAM...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.16.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on: 548163
Blocks: 548844
 
 
Reported: 2009-08-16 14:06 UTC by Leonardo Ferreira Fontenelle
Modified: 2013-05-26 04:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Handle filename to long errors in Filechooser (1.48 KB, patch)
2013-05-23 07:56 UTC, Timothy Arceri
none Details | Review
Handle filename to long errors in Filechooser (1.41 KB, patch)
2013-05-23 08:14 UTC, Timothy Arceri
none Details | Review

Description Leonardo Ferreira Fontenelle 2009-08-16 14:06:03 UTC
+++ This bug was initially created as a clone of Bug #548163 +++

This works correctly:
1. Click File → Save As... in an application, eg gedit or Evince.
2. Write a file name with an invalid character and press Save.
Result: There will be an error message dialog and the FileChooser dialog will not be closed.

This doesn't work correctly:
1. Click File → Save As... in an application, eg gedit or Evince.
2. Write a too long file name and press Save.
Result: The FileChooser dialog will be closed, and the application will report the error to the user.

Expected result: same as in the first scenario.
Comment 1 Leonardo Ferreira Fontenelle 2009-10-18 23:06:42 UTC
Please, typing long file names is tedious and error prone, don't make me type them again when I pass the length limit. Please make GTK+ handle correctly G_IO_ERROR_FILENAME_TOO_LONG errors.
Comment 2 Federico Mena Quintero 2009-10-19 18:42:23 UTC
This check should probably go in gtk_file_chooser_default_should_respond(), close to the code that checks for already-existing files.  I'll gladly review a patch to do this.
Comment 3 Leonardo Ferreira Fontenelle 2009-10-19 20:59:16 UTC
You might want to advertise this somehow; I can barely write something in Python.
Comment 4 Timothy Arceri 2013-05-23 07:56:38 UTC
Created attachment 245103 [details] [review]
Handle filename to long errors in Filechooser

Here is a patch to display a dialog when filename is too long and keep the filechooser open
Comment 5 Timothy Arceri 2013-05-23 08:14:24 UTC
Created attachment 245107 [details] [review]
Handle filename to long errors in Filechooser

Fixes whitespace issues and removes unused param