GNOME Bugzilla – Bug 591840
configure fails with autoconf 2.64
Last modified: 2010-08-02 08:49:04 UTC
After upgrading to autoconf 2.64, glib configure fails with: checking for GNUC visibility attribute... ./configure: line 31209: syntax error: unexpected end of file I reduced the problem as best as I could and on autoconf-bugs Ralf Wildenhues identified the issue. http://lists.gnu.org/archive/html/bug-autoconf/2009-08/msg00054.html I'll quote his conclusion: > Autoconf 2.64 changed AS_IF a bit to be more compact, and to allow > things like > AS_IF(...) && ... > > as documented in NEWS: > > ** The m4sh macros AS_IF and AS_CASE can now be used in shell lists. > The responsibility for supplying a trailing newline now belongs to > the call site, but since most users did not add dnl, this generally > results in fewer empty lines in configure. > > As a consequence, you need to remove the last dnl in the m4_ifvaln line. > With 2.63, it will lead to a harmless extra newline in the configure > script.
Created attachment 140796 [details] [review] Update GLIB_CHECK_COMPILE_WARNINGS macro to work with Autoconf 2.64 Quoting its NEWS file: "The m4sh macros AS_IF and AS_CASE can now be used in shell lists. The responsibility for supplying a trailing newline now belongs to the call site, but since most users did not add dnl, this generally results in fewer empty lines in configure."
(patch tested with both 2.63 and 2.64)
Thanks, please commit.
commit c24f6e55276fac68b08df34b0d350f65afe994d9 Author: Frédéric Péters <fpeters@0d.be> Date: Fri Aug 14 21:00:41 2009 +0200 Update GLIB_CHECK_COMPILE_WARNINGS macro to work with Autoconf 2.64 Quoting its NEWS file: "The m4sh macros AS_IF and AS_CASE can now be used in shell lists. The responsibility for supplying a trailing newline now belongs to the call site, but since most users did not add dnl, this generally results in fewer empty lines in configure." http://bugzilla.gnome.org/show_bug.cgi?id=591840
Is this one OK to apply to glib-2-20 as well? Work still uses the older glib.
Cherry-picked fpeters' c24f6e552 to glib-2-20.