After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591807 - Orca sometimes presents the previous line when Home/End is pressed in Gecko
Orca sometimes presents the previous line when Home/End is pressed in Gecko
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.21.x
Other All
: Normal normal
: 2.28.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403 404409
 
 
Reported: 2009-08-14 14:19 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (1.68 KB, patch)
2009-08-14 19:47 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-08-14 14:19:57 UTC
Attila commented on bug 584103:
~~~~~~
I see two little  cursor navigating problem. I think the average users doesn't see the following problems, I try tests and see following problems:

If I write a new message and I press enter key, I try press two time the home key, Orca says the previous line beginning character and the cursor jumps
previous line. This problem is only true, if I not write any character the new line after pressed enter key. 

The bigger problem is following:
When I read a message with arrow keys and navigated a blank line, if I try
press home key, Orca (speaks the) previous line beginning character.
~~~~~~
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-08-14 19:26:40 UTC
Confirming both problems as described.
Comment 2 Joanmarie Diggs (IRC: joanie) 2009-08-14 19:32:45 UTC
Sorry for the spam. I can reproduce this in Firefox as well.
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-08-14 19:47:24 UTC
Created attachment 140799 [details] [review]
proposed fix

The problem is that apparently in some circumstances, the line cache is not getting updated. In the spirit of low risk/high impact, this patch solves the problem specifically by getting the line contents rather than using the cached line when Home and End are pressed.

Will, please review. Thanks! (I'll create a new regression test for this issue now.)
Comment 4 Willie Walker 2009-08-14 20:14:46 UTC
(In reply to comment #3)
> Created an attachment (id=140799) [edit]
> proposed fix
> 
> The problem is that apparently in some circumstances, the line cache is not
> getting updated. In the spirit of low risk/high impact, this patch solves the
> problem specifically by getting the line contents rather than using the cached
> line when Home and End are pressed.
> 
> Will, please review. Thanks! (I'll create a new regression test for this issue
> now.)

Looks great to me.  I say commit and thank you!  :-)
Comment 5 Joanmarie Diggs (IRC: joanie) 2009-08-14 20:27:42 UTC
Thanks Will. Patch committed to master along with a regression test for this bug. Closing as FIXED.