After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591290 - permit display of images in list mode
permit display of images in list mode
Status: RESOLVED FIXED
Product: zenity
Classification: Core
Component: general
2.26.x
Other All
: Normal enhancement
: ---
Assigned To: Zenity Maintainers
Zenity Maintainers
Depends on: 592195
Blocks:
 
 
Reported: 2009-08-10 04:05 UTC by Joshua N Pritikin
Modified: 2012-07-20 03:05 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Tidy zenity tree logic (4.48 KB, patch)
2009-08-10 04:07 UTC, Joshua N Pritikin
none Details | Review
add imagelist support (4.80 KB, patch)
2009-08-10 04:08 UTC, Joshua N Pritikin
none Details | Review
add imagelist support (4.81 KB, patch)
2009-08-18 10:45 UTC, Joshua N Pritikin
none Details | Review

Description Joshua N Pritikin 2009-08-10 04:05:06 UTC
It would be really cool if zenity could interpret a column as pathnames to images.
Comment 1 Joshua N Pritikin 2009-08-10 04:07:49 UTC
Created attachment 140295 [details] [review]
Tidy zenity tree logic
Comment 2 Joshua N Pritikin 2009-08-10 04:08:36 UTC
Created attachment 140296 [details] [review]
add imagelist support

Caveats:

1. I load the images on-demand into a hash table. There is no attempt to
deallocate the hash table or images.

2. Something (GtkTreeView?) is forcing the height of the window to
display some number of rows. This causes the mimimum height of the
window to exceed the height of the screen on small screens or when rows
have a large height.
Comment 3 Joshua N Pritikin 2009-08-10 04:09:27 UTC
Another possibility is to permit the image to appear in other columns
besides column #1 so long as there is no column with both check/radio
buttons and the image.
Comment 4 Joshua N Pritikin 2009-08-18 10:45:59 UTC
Created attachment 141049 [details] [review]
add imagelist support
Comment 5 Joshua N Pritikin 2009-08-18 10:48:41 UTC
On further reflection, I believe not deallocating images is a feature, not a bug. See bug 592195.
Comment 6 Arx Cruz 2012-04-19 20:39:38 UTC
I'll take a look in this patch, seems to be nice have image support.
Comment 7 Joshua N Pritikin 2012-04-19 20:51:06 UTC
Great, it would be nice to get some closure on these patches after almost 3 years. :-)
Comment 8 Arx Cruz 2012-05-08 20:37:19 UTC
Hehe, sorry, it's a lot of bugs to check, and I'm only one, would be nice if others contribute with patches, not only opening bugs. If you want to contribute more, please contact me ;)

I'm still didn't have chance to see this patch, I'll try work on this one over the weekend.
Comment 9 Arx Cruz 2012-07-19 17:26:13 UTC
I did a few changes in the nomenclature to conforms zenity and it's comited on master. Thanks!

http://git.gnome.org/browse/zenity/commit/?id=c17eff5863009c69196e92520b150643f1f7937d
Comment 10 Joshua N Pritikin 2012-07-20 03:05:37 UTC
Awesome! Better late than never. :-)