After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590417 - terminal asks to close even when no process running
terminal asks to close even when no process running
Status: RESOLVED FIXED
Product: nautilus-open-terminal
Classification: Other
Component: general
0.13
Other All
: Normal minor
: ---
Assigned To: Christian Neumair
Christian Neumair
Depends on:
Blocks:
 
 
Reported: 2009-07-31 20:53 UTC by whatsinaname
Modified: 2009-08-03 20:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to use exec when running the target shell (1.51 KB, patch)
2009-08-01 14:49 UTC, Evangelos Foutras
committed Details | Review

Description whatsinaname 2009-07-31 20:53:19 UTC
Please describe the problem:
When using the nautilus-open terminal context menu entry to open a terminal, closing that terminal generates a warning that there is a process still running, even when I have just opened the terminal.

Steps to reproduce:
1. right click in a nautilus window
2. chose "open in terminal"
3. close the terminal that opens



Actual results:
it asks me if I am sure I want to close and tells me that there is a process still running.

Expected results:
I would expect it to close, since I didn't do anything in the terminal.

Does this happen every time?
Yes.

Other information:
Comment 1 Evangelos Foutras 2009-08-01 14:49:20 UTC
Created attachment 139690 [details] [review]
Patch to use exec when running the target shell

Using exec to replace the helper shell (/bin/sh) with the target shell seems to solve this issue for me. I'm not sure if this method has any side effects though, so it needs review from someone more knowledgeable.
Comment 2 Christian Neumair 2009-08-03 10:10:55 UTC
Thanks for your efforts. The sh manpage actually seems to list exec as a valid way to replace the current sh binary with something else. Therefore, your patch looks safe. We'll see whether it causes problems for anybody.

I just applied it to trunk:

http://git.gnome.org/cgit/nautilus-open-terminal/commit/?id=357a768b063ced123afaaf60322fd7076e806e1e.

Closing.
Comment 3 Christian Neumair 2009-08-03 10:28:51 UTC
I just released Nautilus Open Terminal 0.14.
Comment 4 whatsinaname 2009-08-03 20:11:31 UTC
works for me... thanks a bunch.