After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589897 - broken code in gap/gap_vin.c: gap_vin_get_all_keylist()
broken code in gap/gap_vin.c: gap_vin_get_all_keylist()
Status: RESOLVED FIXED
Product: gimp-gap
Classification: Other
Component: general
Current SVN
Other Linux
: Normal normal
: ---
Assigned To: hof
hof
Depends on:
Blocks:
 
 
Reported: 2009-07-27 16:19 UTC by Stanislav Brabec
Modified: 2010-09-09 09:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Stanislav Brabec 2009-07-27 16:19:11 UTC 
David Binderman pointed in https://bugzilla.novell.com/show_bug.cgi?id=525319 to an apparently broken code in gap_vin_get_all_keylist().

It allocates a space for a structure, fills it with useful values, does never use it, does never reference it, and then it returns without freeing it.

I don't have an insight to the code, that is why I am not attaching a patch.

Maybe argument GapVinVideoInfo **vin_ptr and vin_ptr = l_vin_ptr was intended, maybe win_ptr should be used instead of l_vin_ptr and its allocation, maybe there is missing code using l_vin_ptr.

Please check.
Comment 1 hof 2010-09-09 09:04:19 UTC 
This bug is already fixed, colsing as fixed now.

Cahngelog: 2009-07-28
- fixed broken initialisation of default values in case the file
  with animation properties (*_vin.gap) does not yet exist.
  This also fixes the reported resource bug #589897
  (that allocated memory for GapVinVideoInfo structure
   that was never freed)


  * gap/gap_vin.c