GNOME Bugzilla – Bug 589525
gnlfilesource always uses decodebin, not decodebin2
Last modified: 2009-07-27 18:16:34 UTC
There used to be code in gnlfilesource.c which caused gnlfilesource to use decodebin2 when USE_DECODEBIN2 was set. That code has recently disappeared, and gnlfilesource now always uses decodebin if available (and falls back on decodebin2 otherwise). Was this actually the intention of whoever made this change? From looking at the code, it seems as if they may have intended decodebin2 to be the default, but got it wrong.
Created attachment 139100 [details] [review] fix Here's a patch which we can apply to make gnlfilesource use decodebin2 by default if that's what was intended.
commit 615caa12be22c73ee9ef3bf7c608d0b3843c4675 Author: Adam Dingle <adam@yorba.org> Date: Mon Jul 27 20:07:21 2009 +0200 gnlfilesource: Really use decodebin2. Fixes #589525