After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589525 - gnlfilesource always uses decodebin, not decodebin2
gnlfilesource always uses decodebin, not decodebin2
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gnonlin
git master
Other Linux
: Normal blocker
: 0.10.12
Assigned To: GStreamer Maintainers
Edward Hervey
Depends on:
Blocks:
 
 
Reported: 2009-07-23 19:14 UTC by Adam Dingle
Modified: 2009-07-27 18:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
fix (650 bytes, patch)
2009-07-23 19:24 UTC, Adam Dingle 		committed Details | Review

Description Adam Dingle 2009-07-23 19:14:40 UTC 
There used to be code in gnlfilesource.c which caused gnlfilesource to use decodebin2 when USE_DECODEBIN2 was set.  That code has recently disappeared, and gnlfilesource now always uses decodebin if available (and falls back on decodebin2 otherwise).  Was this actually the intention of whoever made this change?  From looking at the code, it seems as if they may have intended decodebin2 to be the default, but got it wrong.
Comment 1 Adam Dingle 2009-07-23 19:24:05 UTC 
Created attachment 139100 [details] [review]
fix

Here's a patch which we can apply to make gnlfilesource use decodebin2 by default if that's what was intended.
Comment 2 Edward Hervey 2009-07-27 18:16:34 UTC 
commit 615caa12be22c73ee9ef3bf7c608d0b3843c4675
Author: Adam Dingle <adam@yorba.org>
Date:   Mon Jul 27 20:07:21 2009 +0200

    gnlfilesource: Really use decodebin2. Fixes #589525