After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589072 - Get rid of deprecated libgnome(ui)
Get rid of deprecated libgnome(ui)
Status: RESOLVED OBSOLETE
Product: gnome-commander
Classification: Other
Component: application
1.2.x
Other Linux
: Normal normal
: 2.0
Assigned To: GNOME Commander maintainer(s)
epiotr
Depends on: 570733 571236 571495
Blocks:
 
 
Reported: 2009-07-20 00:10 UTC by André Klapper
Modified: 2018-08-03 17:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Replace generic #include libgnome(ui) header lines by specific ones (6.18 KB, patch)
2010-04-07 23:25 UTC, André Klapper
committed Details | Review

Description André Klapper 2009-07-20 00:10:05 UTC
Get rid of 

libgnome(ui) will be removed for GNOME3 in a few months.

See http://live.gnome.org/LibgnomeMustDie for more information.
Also see http://www.gnome.org/~fpeters/299.html and http://live.gnome.org/AndreKlapper/GCDS3 for a list of other applications and to study their patches for similar issues. Might save some time.


It seems like gnome-commander only includes generic headers.
This makes it way harder to find about about the complexity of this task. :-(


./plugins/fileroller/file-roller-plugin.c:#include <gnome.h>
./plugins/test/test-plugin.c:#include <gnome.h>
./plugins/cvs/interface.c:#include <gnome.h>
./plugins/cvs/parser.h:#include <gnome.h>
./plugins/cvs/cvs-plugin.c:#include <gnome.h>
./libgcmd/libgcmd-deps.h:#include <libgnome/libgnome.h>
./libgcmd/libgcmd-deps.h:#include <libgnome/gnome-i18n.h>
./libgcmd/libgcmd-deps.h:#include <libgnomeui/libgnomeui.h>
./src/intviewer/viewer-widget.cc:#include <libgnome/libgnome.h>
./src/intviewer/search-progress-dlg.cc:#include <libgnome/libgnome.h>
./src/intviewer/viewer-utils.cc:#include <libgnomeui/libgnomeui.h>
./src/intviewer/viewer-utils.cc:#include <libgnome/libgnome.h>
./src/intviewer/search-dlg.cc:#include <libgnome/libgnome.h>
./src/intviewer/viewer-window.cc:#include <libgnomeui/libgnomeui.h>
./src/intviewer/viewer-window.cc:#include <libgnome/libgnome.h>
./tests/gviewer/search_dlg_test.c:#include <libgnomeui/libgnomeui.h>
./tests/gviewer/viewerwindow.c:#include <libgnomeui/libgnomeui.h>

...plus configure.in.
Comment 1 André Klapper 2010-04-07 23:25:23 UTC
Created attachment 158151 [details] [review]
Replace generic #include libgnome(ui) header lines by specific ones

As such generic linking also drags in for example libart, libbonobo, this is an initial patch to have some lighter linking at least.
No idea if this is clean, but everything compiles for me.
Comment 2 epiotr 2010-04-09 18:36:12 UTC
Review of attachment 158151 [details] [review]:

Thanks, I've just committed the patch. I'm not closing the bug, as libgnome/libgnomeui dependency still needs more cleanup.
Comment 3 André Klapper 2010-04-28 23:46:12 UTC
To update the to-do list for potential contributors:

./libgcmd/libgcmd-deps.h:#include <libgnome/gnome-config.h>
./src/intviewer/viewer-utils.cc:#include <libgnome/gnome-config.h>
./libgcmd/libgcmd-deps.h:#include <libgnome/gnome-exec.h>
./src/utils.h:#include <libgnome/gnome-help.h>

./libgcmd/libgcmd-deps.h:#include <libgnomeui/gnome-app-helper.h>
./libgcmd/libgcmd-deps.h:#include <libgnomeui/gnome-icon-entry.h>
./src/gnome-cmd-dir-indicator.cc:#include <libgnomeui/gnome-popup-menu.h>
./src/gnome-cmd-file-list.cc:#include <libgnomeui/gnome-popup-menu.h>
./plugins/test/test-plugin.cc:#include <libgnomeui/gnome-dialog-util.h>
./plugins/cvs/cvs-plugin.cc:#include <libgnomeui/gnome-dialog-util.h>
./src/gnome-cmd-main-win.cc:#include <libgnomeui/gnome-stock-icons.h>
./src/gnome-cmd-main-menu.cc:#include <libgnomeui/gnome-stock-icons.h>
./src/gnome-cmd-file-popmenu.cc:#include <libgnomeui/gnome-stock-icons.h>
./src/gnome-cmd-about-plugin.cc:#include <libgnomeui/gnome-stock-icons.h>
./src/gnome-cmd-user-actions.cc:#include <libgnomeui/gnome-url.h>
./src/gnome-cmd-about-plugin.cc:#include <libgnomeui/gnome-href.h>
./src/gnome-cmd-smb-auth.cc:#include <libgnomeui/gnome-password-dialog.h>
./src/main.cc:#include <libgnomeui/gnome-ui-init.h>
./tests/gviewer/search_dlg_test.c:#include <libgnomeui/gnome-ui-init.h>
./tests/gviewer/viewerwindow.c:#include <libgnomeui/gnome-ui-init.h>
Comment 4 GNOME Infrastructure Team 2018-08-03 17:57:04 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-commander/issues/34.