GNOME Bugzilla – Bug 589045
Remove deprecated libgnome(ui) dependency
Last modified: 2013-03-05 17:24:53 UTC
http://live.gnome.org/LibgnomeMustDie libgnome and libgnomeui will be removed for GNOME 3 in a few months. Work left to do after fixing bug 584009 and bug 349304 that both have patches: ./src/planner-sql-plugin.c:#include <libgnomeui/gnome-entry.h> ./src/planner-main.c:#include <libgnome/gnome-program.h> ./src/planner-main.c:#include <libgnomeui/gnome-ui-init.h> ./eds-backend/utils/create-planner-source.c:#include <libgnome/gnome-init.h> ./eds-backend/planner-source/planner-source.c:#include <libgnome/gnome-i18n.h> ./eds-backend/e-cal-backend-planner.c:#include <libgnome/gnome-i18n.h>
The last two ones should be a simple -#include <libgnome/gnome-i18n.h> +#include <glib/gi18n.h> Okay to commit?
ping?
Hello, Could any planner developer review this?
Come fixes committed: 8b9104f145b722dc427ea6f1216e305ad16a64e3 Use gtk_init_with_args() instead GnomeProgram cae485d1d4dcc14544dd3cf664dbb29e63e91e40 Use gtk_show_uri instead of gnome_help_display and gnome_url_show ce9da9b7ed30ec19508c3be5e8b38e1fa438eef2 Use gtk_init() instead gnome_program_init() c982ae3c1ac13b6fdb672d0d3140e8477d18305d Remove unneded libgnome/gnome-i18n.h includes So the only remaining include is: ./src/planner-sql-plugin.c:#include <libgnomeui/gnome-entry.h> that should be fixed here or with the bug to port to GtkBuilder from libglade ( bug #589700 )
Created attachment 238019 [details] [review] Remove deprecated GnomeEntry. It is replaced by GtkEntry. This means we lose the history functionality, but that could be reimplemented using GtkComboBoxText with an entry.
Created attachment 238020 [details] [review] Remove deprecated libgnomeui.
Review of attachment 238019 [details] [review]: Please push this.
Review of attachment 238020 [details] [review]: This as well.
Pushed. commit fd8da8994f7006b9fcefc90d2fe5c2b484c7871e Author: Luis Menina <liberforce@freeside.fr> Date: Mon Mar 4 14:42:22 2013 +0100 Remove deprecated libgnomeui. https://bugzilla.gnome.org/show_bug.cgi?id=589045 commit cd2b658e83d47e8f49d1bbaf54be6433a21d3758 Author: Luis Menina <liberforce@freeside.fr> Date: Mon Mar 4 18:10:26 2013 +0100 Remove deprecated GnomeEntry. It is replaced by GtkEntry. This means we lose the history functionality, but that could be reimplemented using GtkComboBoxText with an entry. https://bugzilla.gnome.org/show_bug.cgi?id=589045