GNOME Bugzilla – Bug 588812
Group 1-to-1 chats in one window and MUC's in another one
Last modified: 2009-12-07 17:00:10 UTC
Grouping 1-to-1 (private) chats in one window and MUC's (room) in a different one could help the user to organizer better its tabs.
Small patch for that: http://git.collabora.co.uk/?p=user/abner/empathy.git;a=shortlog;h=refs/heads/new-msg-grouping
Looks mostly fine. The one thing that bothers me is that it only checks if the current visible chat is a room instead of checking if the window has any chats. IMHO you should add a empathy_chat_window_has_room function to EmpathyChatWindow and use that to decide whether it's suitable or not
*** Bug 591528 has been marked as a duplicate of this bug. ***
Travis provided some specific UI design thoughts in bug #591528 that may be useful.
Created attachment 149258 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/separate-muc-588812 src/empathy-chat-window.c | 31 +++++++++++++++++++++++++++++-- src/empathy-chat-window.h | 3 ++- 2 files changed, 31 insertions(+), 3 deletions(-)
Review of attachment 149258 [details] [review]: ::: src/empathy-chat-window.c @@ +1849,3 @@ */ EmpathyChatWindow * +empathy_chat_window_get_default (gboolean room_filter) Given that this isn't used just to filter things but actually both the true and the false value are meaningfull the name seems wrong @@ +1876,3 @@ + nb_rooms = empathy_chat_window_get_nb_rooms (chat_window); + + /* We add a new room only if the window has at least one room */ Comment isn't clear here, something like ``Skip the window if there aren't any rooms in it'' would be better @@ +1880,3 @@ + continue; + + /* We add a new 1-1 chat only if the window has at least one 1-1 chat */ This comment is a lie, the code below doesn't do that
Review of attachment 149258 [details] [review]: ::: src/empathy-chat-window.c @@ +1849,3 @@ */ EmpathyChatWindow * +empathy_chat_window_get_default (gboolean room_filter) renamed to room. @@ +1876,3 @@ + nb_rooms = empathy_chat_window_get_nb_rooms (chat_window); + + /* We add a new room only if the window has at least one room */ I changed both comments.
Fixed in master. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.