After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588040 - support xrandr 1.3 'primary output'
support xrandr 1.3 'primary output'
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Matthias Clasen
Desktop Maintainers
Depends on:
Blocks: randr-tracker 588041
 
 
Reported: 2009-07-08 05:07 UTC by Matthias Clasen
Modified: 2010-01-26 23:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (7.21 KB, patch)
2009-07-08 05:08 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2009-07-08 05:07:35 UTC
Xrandr adds a concept of 'primary output' which is supposed to be the monitor on which the desktop displays its main panels/menus. 

Here is a patch which adds a <primary> tag to the <output> elements in monitor.xml, and adds new api

gboolean  gnome_rr_output_get_primary (GnomeRROutput *output);
+void     gnome_rr_output_set_primary (GnomeRROutput *output);


If Xrandr 1.3 is not available, this should silently do nothing. 

Lightly tested.
Comment 1 Matthias Clasen 2009-07-08 05:08:07 UTC
Created attachment 138015 [details] [review]
patch
Comment 2 Vincent Untz 2009-07-28 16:10:40 UTC
Federico: can you review this?
Comment 3 Federico Mena Quintero 2009-07-28 17:30:21 UTC
Note to self: bug #588041 has a patch to make gnome-display-properties use this Primary property for the "Include panel" checkbox.
Comment 4 Federico Mena Quintero 2009-07-28 20:42:25 UTC
Vuntz says that we are API frozen, but gnome-desktop is in the desktop modules.  Please go ahead and commit with the following changes:

- s/gnome_rr_output_get_primary/gnome_rr_output_get_is_primary

- Make gnome_rr_output_set_primary() take both a GnomeRRScreen and an output.  If output == NULL, make it call XRRSetOutputPrimary(..., None).  Hmm, maybe this function should be called gnome_rr_screen_set_primary_output() instead?

- In crtc_assignment_apply(), I think you'll want to call set_primary(..., NULL) right after grabbing the display (i.e. disable any primary outputs there were).

Don't commit the changes to gnome-control-center just yet... I want to see what the panel requires, and what kind of UI we want for this.  Gnome-shell may indeed require the concept of a primary output, so let's keep this API available in gnome-desktop for now.
Comment 5 Matthias Clasen 2009-07-30 01:07:31 UTC
Committed with the requested changes.
Comment 6 Federico Mena Quintero 2009-07-30 16:57:07 UTC
Hmm, did you forget to commit the requested changes? :)
Comment 7 Vincent Untz 2009-08-19 21:41:41 UTC
I put a patch in bug 562944 for gnome-panel.
Comment 8 Nick Brown 2009-10-09 13:04:47 UTC
I assume this can be marked as resolved if its been committed?
Comment 9 Jeremy Nickurak 2009-12-11 21:01:56 UTC
588041 doesn't actually have any attachments.

Was anything commited?
Comment 11 Federico Mena Quintero 2010-01-26 21:56:52 UTC
This is committed indeed.  Closing the bug.
Comment 12 Jeremy Nickurak 2010-01-26 22:44:15 UTC
Asking here just in case: Does anybody here have the patch that was supposed to be attached to related bug #588041, which is enables the GUI for this option?
Comment 13 Felix Möller 2010-01-26 23:17:24 UTC
Sadly I have no idea how to get that patch. The downstream bugreport for it at https://bugzilla.redhat.com/show_bug.cgi?id=510145 does not have anything attached either. In addition the bug is referenced to from https://bugzilla.gnome.org/show_bug.cgi?id=562944#c27 ...

How this should look like is shown in https://bugzilla.gnome.org/show_bug.cgi?id=562944#c5