GNOME Bugzilla – Bug 587890
Gvfs won't build if libsoup is compiled without gnome support
Last modified: 2013-10-25 20:08:02 UTC
Please describe the problem: Currently, the gvfs http backend makes use of SOUP_TYPE_PROXY_RESOLVER_GNOME provided by libsoup-gnome.h However, if libsoup is built without gnome support, gvfs' http backend fails to build. I have attached a patch to add an additional check to fallback to libsoup if libsoup-gnome is absent. This will let the gvfs http backend use SOUP_TYPE_PROXY_RESOLVER provided by soup-proxy-resolver.h. Steps to reproduce: 1. Build libsoup with --without-gnome 2. Build gvfs against libsoup Actual results: gvfs fails to build because it is unable to find libsoup-gnome-2.4 Expected results: gvfs should fallback to use libsoup-2.4 Does this happen every time? yes Other information: I have attached a patch to workaround this.
Created attachment 137916 [details] [review] Patch to workaround this issue. Attached patch to fix this.
SOUP_TYPE_PROXY_RESOLVER is an interface, not an instantiable type. If you wanted to support building without libsoup-gnome support, then the right thing to do would be to not use a proxy resolver at all in that case. It is not clear why you would want to do this though, since it would only make sense for building gvfs on a system without GNOME, which is pretty much a contradiction.
I need to install gvfs (with HTTP support) in a server. (In reply to comment #2) > It is not clear why you would want to do this though, since it would only make > sense for building gvfs on a system without GNOME, which is pretty much a > contradiction.
gvfs ought to be using SOUP_TYPE_PROXY_RESOLVER_DEFAULT at this point, and no longer needs to link against libsoup-gnome
Created attachment 256987 [details] [review] http: Clean up usage of libsoup Use libsoup rather than libsoup-gnome since libsoup-gnome is not required anymore. Bump the libsoup requirement to 2.42 to prevent a build failure with old libsoups (undefined references to soup_session_request_uri). Don't include individual libsoup headers as recommended by the libsoup documentation.
Review of attachment 256987 [details] [review]: It looks good.
Pushed to master as 2041889.