Bug 587601 – Get rid of shave with AM_SILENT_RULES automake option

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 587601 - Get rid of shave with AM_SILENT_RULES automake option


Summary:	Get rid of shave with AM_SILENT_RULES automake option


Status:	RESOLVED FIXED

Product:	gnome-games-superseded
Classification:	Deprecated
Component:	general
Version:	trunk
Hardware:	Other Linux

Importance:	Normal enhancement
Target Milestone:	---
Assigned To:	gnome-games-general-maint
QA Contact:	GNOME Games maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-07-02 12:31 UTC by Javier Jardón (IRC: jjardon)
Modified:	2009-08-16 19:32 UTC

See Also:
GNOME target:	---
GNOME version:	Unversioned Enhancement

Attachments
Get rid of shave with AM_SILENT_RULES automake option (10.66 KB, patch) 2009-07-02 12:33 UTC, Javier Jardón (IRC: jjardon)	none	Details \| Review
Use AM_SILENT_RULES if automake >= 1.11 is installed (1.02 KB, patch) 2009-07-12 13:50 UTC, Javier Jardón (IRC: jjardon)	none	Details \| Review

Description Javier Jardón (IRC: jjardon) 2009-07-02 12:31:35 UTC

automake1.11 has a feature that do the same as shave do.
IMO would be better to "require newer version of existing tool" than to drag in a new special-purpose widget.
Also, automake1.11 has already been added to gnome-autogen.sh

The default build behavior is "same as previous" (i.e., verbose), but now user
can choose quiet by "./configure --enable-silent-rules" or "make V=0".
Alternately, AM_SILENT_RULES([yes]) makes quiet the default (same default as
shave), and user can "./configure --disable-silent-rules" or "make V=1" to
override.

A hard dependency on automake 1.11 is not necessary. Only add

m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])])


to your configure.ac and should work and still be compatible with earlier automake versions.

More info here: http://live.gnome.org/GnomeGoals/NicerBuilds and bug #580062

Comment 1 Javier Jardón (IRC: jjardon) 2009-07-02 12:33:36 UTC

Created attachment 137729 [details] [review]
Get rid of shave with AM_SILENT_RULES automake option

Comment 2 Christian Persch 2009-07-02 21:16:12 UTC

We could even support both shave for am <= 1.10 and the new thing for 1.11, I think:

m4_ifdef([AM_SILENT_RULES],
  [AM_SILENT_RULES([yes])],
  [SHAVE_INIT([],[enable])
   AC_CONFIG_FILES([shave shave-libtool])])

(untested, but ought to work)

Comment 3 Javier Jardón (IRC: jjardon) 2009-07-12 13:50:07 UTC

Created attachment 138273 [details] [review]
Use AM_SILENT_RULES if automake >= 1.11 is installed

Thank you Christian for the tip!

Comment 4 Christian Persch 2009-08-13 13:54:11 UTC

I think we also need to sprinkle some $(AM_V_GEN) around, e.g. when generating the marshalers, etc.

Plus, I think we should default to "no", not "yes".

Comment 5 Christian Persch 2009-08-16 19:32:48 UTC

Fixed in master. I left shave support in for now; we can always get rid of it later.