After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587216 - Retry option whenever account connecting fails
Retry option whenever account connecting fails
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on: 599176
Blocks:
 
 
Reported: 2009-06-28 16:26 UTC by Praveen Thirukonda
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Display a retry button instead of "Edit account" (3.36 KB, patch)
2009-08-20 04:59 UTC, Louis-Francis Ratté-Boulianne
none Details | Review
Use (ugly) tabs indentation everywhere (3.34 KB, patch)
2009-08-20 05:02 UTC, Louis-Francis Ratté-Boulianne
rejected Details | Review

Description Praveen Thirukonda 2009-06-28 16:26:33 UTC
whenever a account fails to connect in empathy only the message along with edit button is available a retry option should be there.
Comment 1 Frederic Peters 2009-08-14 19:24:24 UTC
Actually Empathy could try to be smarter on this:

 - display "edit" when:
   - it's an account that never connected successfully (new, or just modified)
   - the error is "invalid credentials"

 - display "try reconnecting" otherwise

Probably it could be refined even more but I believe this to be a good start.
Comment 2 Louis-Francis Ratté-Boulianne 2009-08-20 04:59:03 UTC
Created attachment 141212 [details] [review]
Display a retry button instead of "Edit account"

With this patch, a Retry button is displayed instead of the Edit one when the error is one of those:

- None_Specified
- Network_Error

Feel free to suggest another button name or image.
Comment 3 Louis-Francis Ratté-Boulianne 2009-08-20 05:02:47 UTC
Created attachment 141213 [details] [review]
Use (ugly) tabs indentation everywhere
Comment 4 Guillaume Desmottes 2009-10-21 11:51:19 UTC
We want this in 2.30. Maybe we should wait that the dialog has switched to GtkInfoBar though (bug #599176).
Comment 5 Guillaume Desmottes 2009-10-22 09:10:06 UTC
Comment on attachment 141213 [details] [review]
Use (ugly) tabs indentation everywhere

Let's fix bug #599176 first.
Comment 6 André Klapper 2009-10-28 17:16:50 UTC
Currently 17 Empathy tickets are set as GNOME 2.30 blockers, hence mass-removing.
Guillaume: Please use normal Target Milestones instead. If you really think that this specific issue here is a 2.30 blocker then please restore the GNOME target and set corresponding importance values.
Comment 7 Felix Kaser 2009-10-29 12:30:18 UTC
There are currently some changes going on on the ui.

there are some screenshots available here: http://people.collabora.co.uk/~kaserf/

Obviously there are to many buttons in the InfoBar which make it really big. After some discussion on IRC sjoerd came up with a nice idea:

<sjoerd> having an X button and make the account name a GtkLinkButton which takes you to the accounts UI?

It would strip down the buttons to one (close) and keep the possibility to edit the account with the gtklinkbutton.

As for the retry there are some plans to integrate that functionality in the accounts dialog.
Comment 8 Guillaume Desmottes 2009-11-10 15:10:21 UTC
This has been fixed with the new info bar.