After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586539 - Speedup initializaion of DocInfo objects
Speedup initializaion of DocInfo objects
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-21 15:34 UTC by Siegfried Gevatter (RainCT)
Modified: 2009-06-22 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The described patch (1.82 KB, patch)
2009-06-21 15:35 UTC, Siegfried Gevatter (RainCT) 		none Details | Review
Oops, put a "let" in the wrong place (1.84 KB, patch)
2009-06-21 15:42 UTC, Siegfried Gevatter (RainCT) 		none Details | Review
yay for testing.. (2.85 KB, patch)
2009-06-22 12:25 UTC, Siegfried Gevatter (RainCT) 		none Details | Review

Description Siegfried Gevatter (RainCT) 2009-06-21 15:34:20 UTC 
The provided patch moves the Shell.get_thumbnail call from DocInfo.prototype._init to getIcon (so that it's only called when it's actually needed; we don't need to load the icon for all the hundreds of recently used items paginated in the overlay at startup) and disables that call when the URI isn't a local file as doing that lookup for http(s):// locations is very slow.

On my Zeitgeist integration branch, not using that patch gnome-shell hangs at startup for several minutes.
Comment 1 Siegfried Gevatter (RainCT) 2009-06-21 15:35:01 UTC 
Created attachment 137120 [details] [review]
The described patch
Comment 2 Siegfried Gevatter (RainCT) 2009-06-21 15:42:01 UTC 
Created attachment 137121 [details] [review]
Oops, put a "let" in the wrong place
Comment 3 Siegfried Gevatter (RainCT) 2009-06-22 12:25:22 UTC 
Created attachment 137168 [details] [review]
yay for testing..
Comment 4 Dan Winship 2009-06-22 13:35:53 UTC 
shouldn't it still cache the thumbnail as this._iconPixbuf? or are future calls to it guaranteed to be pretty fast since it will have already generated a thumbnail at that point?
Comment 5 Dan Winship 2009-06-22 13:42:04 UTC 
(answered on irc: "future calls should be rather fast as the thumbnail is cached")

committed and pushed