After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 58628 - GtkAccelLabel should refetch accelerator when set_accel_object is called
GtkAccelLabel should refetch accelerator when set_accel_object is called
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
1.3.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2001-08-06 14:58 UTC by James Henstridge
Modified: 2011-02-04 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
refetch accels on set_accel_object() (533 bytes, patch)
2001-08-06 14:59 UTC, James Henstridge
none Details | Review

Description James Henstridge 2001-08-06 14:58:03 UTC
When gtk_accel_label_set_accel_object() is called on a GtkAccelLabel, the
label should be fetching the accelerators on that object.

It doesn't now, which means that if no accelerators are set on the object
being watched by the the GtkAccelLabel, it won't show the accelerators that
were set prior to set_accel_object().

Also, if the accel object is unset (passing NULL to set_accel_object()),
the label will continue to show the last state of the previous accel
object.  I haven't verified this behaviour though.

The simple fix is to add a call to gtk_accel_label_refetch() in
gtk_accel_label_set_accel_object().  Patch to do this is attached below.
Comment 1 James Henstridge 2001-08-06 14:59:11 UTC
Created attachment 856 [details] [review]
refetch accels on set_accel_object()
Comment 2 James Henstridge 2001-08-25 03:34:13 UTC
I applied the patch for this bug a while ago, but forgot to close the
ticket.  Closing it now.