After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585680 - Unable to extract files multiple-rar archive from gvfs
Unable to extract files multiple-rar archive from gvfs
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.26.x
Other All
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-13 20:25 UTC by Jean-Louis Dupond
Modified: 2009-07-22 14:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Example patch! (4.05 KB, patch)
2009-06-23 08:11 UTC, Jean-Louis Dupond 		none Details | Review

Description Jean-Louis Dupond 2009-06-13 20:25:54 UTC 
Please describe the problem:
Its not possible to extract an multiple file archive (rar, r00, r01 etc) from a gvfs system (like samba). 

Because file-roller copies only the .rar file into /home/user/.cache/fr-xxxxx and not the rest of the files. So not all files gets found :)

Steps to reproduce:
Just extract a rar archive with multiple files from a gvfs share!

Actual results:
File not found, and archive not extracted!
It also leaves a copy of the rar in /home/user/.cache/fr-xxxx :(

Expected results:


Does this happen every time?
YES

Other information:
Comment 1 Jean-Louis Dupond 2009-06-22 21:43:51 UTC 
I've been trying to fix the problem. My opinion is that it shouldn't copy the files to a cache dir then extract it to a temp dir, and then copy it back to the share. Its just possible to use the /home/xxx/.gvfs/share/file.rar and extract directly from the share & put it back!

Why:
1) Its now possible to extract multiple file rars from a gvfs share (like samba share)
2) No overhead of copying all the files!
3) When u want to extract an archive with alot of files, or a big archive, u would need ALOT of free space to be able to do it! If u extract like a 5GB archive, it gonne need 5gb temp space to copy the rar + 5 (or even more) GB to extract it!

I've been patching file-roller a bit atm, and I can now perfectly extract multiple rar archives from a gvfs share!


Please give some comment! Like cases this shouldn't be done, any problems this would be causing etc ...
Comment 2 Cosimo Cecchi 2009-06-22 23:01:43 UTC 
(In reply to comment #1)

> I've been patching file-roller a bit atm, and I can now perfectly extract
> multiple rar archives from a gvfs share!
> 
> Please give some comment!

Attaching the patch will probably help you getting comments on this.
Comment 3 Jean-Louis Dupond 2009-06-23 08:11:01 UTC 
Created attachment 137230 [details] [review]
Example patch!

This patch shows how to get rar files extracted from remote without copying the files to temp! This patch is WAY FROM done, but it gives you an idea
Comment 4 Jean-Louis Dupond 2009-07-22 14:48:51 UTC 
This seems fixed into http://git.gnome.org/cgit/file-roller/commit/?id=73fa5d77a60861cd35c6f3425d27c88061af081c