After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585613 - Random by Score shuffle mode
Random by Score shuffle mode
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Playback
git master
Other Linux
: Normal enhancement
: 1.x
Assigned To: Alexander Kojevnikov
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-13 00:19 UTC by Alexander Kojevnikov
Modified: 2009-07-08 17:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Shuffle by Score (10.24 KB, patch)
2009-06-13 05:16 UTC, Alexander Kojevnikov 		none Details | Review
Fixed SQL queries (10.34 KB, patch)
2009-06-14 02:37 UTC, Alexander Kojevnikov 		needs-work Details | Review
Adapted to the new RandomByX classes (19.28 KB, patch)
2009-07-08 16:10 UTC, Alexander Kojevnikov 		committed Details | Review

Description Alexander Kojevnikov 2009-06-13 00:19:45 UTC 
Gabriel suggested to add a new shuffle mode based on song ratings, similar to bug 544680.
Comment 1 Alexander Kojevnikov 2009-06-13 00:23:38 UTC 
erm, Score, not Rating
Comment 2 Alexander Kojevnikov 2009-06-13 05:16:52 UTC 
Created attachment 136483 [details] [review]
Shuffle by Score

This patch groups scores into 20 slots: 1-5, 6-10, ..., 96-100; and uses the same weights as bug 544680 but adjusted to the number of slots: [1, φ^(1/4), φ^(2/4), ..., φ^(19/4)]
Comment 3 Alexander Kojevnikov 2009-06-14 02:37:04 UTC 
Created attachment 136534 [details] [review]
Fixed SQL queries
Comment 4 Gabriel Burt 2009-06-30 17:17:53 UTC 
Thanks Alexander!
Comment 5 Gabriel Burt 2009-07-01 19:23:25 UTC 
I just refactored the random-by code, so the patch now needs work.  Also, I fixed a bug with random by artist/album/rating not working correctly for playlists (see the Query code in RandomByArtist.cs for example)
Comment 6 Alexander Kojevnikov 2009-07-08 16:10:46 UTC 
Created attachment 138050 [details] [review]
Adapted to the new RandomByX classes
Comment 7 Gabriel Burt 2009-07-08 16:55:32 UTC 
Looks good, thanks Alexander :)
Comment 8 Alexander Kojevnikov 2009-07-08 17:14:17 UTC 
Committed, thanks for a quick review!