After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585364 - Get rid of shave with AM_SILENT_RULES automake option
Get rid of shave with AM_SILENT_RULES automake option
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.29.x
Other All
: Normal trivial
: ---
Assigned To: Jonny Lamb
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-10 17:27 UTC by Javier Jardón (IRC: jjardon)
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
Get rid of shave with AM_SILENT_RULES automake option (11.03 KB, patch)
2009-06-10 17:31 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Get rid of shave with AM_SILENT_RULES automake option and AM_V_GEN (20.94 KB, patch)
2009-08-18 16:11 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Get rid of shave with AM_SILENT_RULES automake option and AM_V_GEN.v2 (18.36 KB, patch)
2010-01-17 21:36 UTC, Javier Jardón (IRC: jjardon)
none Details | Review

Description Javier Jardón (IRC: jjardon) 2009-06-10 17:27:25 UTC
automake1.11 has a feature that do the same as shave do.
IMO would be better to "require newer version of existing tool" than to drag in a new special-purpose widget.
Also, automake1.11 has already been added to gnome-autogen.sh

The default build behavior is "same as previous" (i.e., verbose), but now user
can choose quiet by "./configure --enable-silent-rules" or "make V=0".
Alternately, AM_SILENT_RULES([yes]) makes quiet the default (same default as
shave), and user can "./configure --disable-silent-rules" or "make V=1" to
override.

A hard dependency on automake 1.11 is not necessary. Only add

m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])])

to your configure.ac and should work and still be compatible with earlier automake versions.

More info here: http://live.gnome.org/GnomeGoals/NicerBuilds and bug #580062
Comment 1 Javier Jardón (IRC: jjardon) 2009-06-10 17:31:53 UTC
Created attachment 136285 [details] [review]
Get rid of shave with AM_SILENT_RULES automake option
Comment 2 Guillaume Desmottes 2009-06-15 16:07:55 UTC
Jonny: what do you think about this?
Comment 3 Jonny Lamb 2009-06-15 20:43:46 UTC
automake1.11 isn't in Debian yes, so personally I'd request we wait.
Comment 4 Jonny Lamb 2009-08-18 13:54:49 UTC
Now that automake1.11 is in Debian, I'd be more willing to accept this.

However, the build is far from silent due to all the codegen we get up to. What can AM_SILENT_RULES do about these custom rules, or must we continue using the $(QUIET_GEN) hack?
Comment 5 Frederic Peters 2009-08-18 14:15:53 UTC
That would be $(AM_V_GEN) (see <http://www.flameeyes.eu/autotools-mythbuster/automake/silent.html#id454914>).
Comment 6 Jonny Lamb 2009-08-18 15:54:02 UTC
Ah, thanks Frederic.

Javier, could you possibly update your patch to use AM_V_GEN as documented in the link Frederic gave?

Thanks,
Comment 7 Javier Jardón (IRC: jjardon) 2009-08-18 16:11:30 UTC
Created attachment 141093 [details] [review]
Get rid of shave with AM_SILENT_RULES automake option and AM_V_GEN

Reworked patch. I've used AM_V_GEN to subsitute QUIET_GEN.
Comment 8 Jonny Lamb 2009-08-24 09:56:18 UTC
Cool. I tried the patch and it looks better. However, this highlights a few points where we hadn't used QUIET_GEN where we should have, because some other rubbish is output.

Could you add some more AM_V_GEN to custom rules which still make noise (some in po, some in help) -- don't worry about gtk-doc though; its verbosity is sometimes useful, and it's not always built.

Thanks again!
Comment 9 Guillaume Desmottes 2009-10-20 10:09:08 UTC
Let's merge this for 2.30.
Comment 10 Jonny Lamb 2009-10-20 11:52:12 UTC
This is actually harder than I first thought.

shave defaults to stifling output. automake 1.11 defaults to printing output.

This means that with a blind move from shave to automake, replacing QUIET_GEN with AM_V_GEN, there is still a lot of output. For example, the po and help Makefiles are generated from intltool (?) and gnome-doc-utils, and don't have any custom rule silencing, so make a lot of noise. I guess the real point of silent builds is so that warnings and errors are more visible... We do build with Werror though. The python bindings also make a lot of noise, and although it was a while ago, making them quieter was harder than it sounds.

We might be removing the python bindings some time soon so I've just made this bug depend on the gnome-doc-utils and gtk-doc bugs asking for quiet rules support.
Comment 11 André Klapper 2009-10-28 17:16:46 UTC
Currently 17 Empathy tickets are set as GNOME 2.30 blockers, hence mass-removing.
Guillaume: Please use normal Target Milestones instead. If you really think that this specific issue here is a 2.30 blocker then please restore the GNOME target and set corresponding importance values.
Comment 12 Guillaume Desmottes 2009-11-12 11:05:32 UTC
Assigning to Jonny as he's our shave/silent build guy.

Jonny: We don't use gtk-doc anymore so I guess we can remove the dependency on bug #590927.
Comment 13 Javier Jardón (IRC: jjardon) 2010-01-17 21:36:46 UTC
Created attachment 151629 [details] [review]
Get rid of shave with AM_SILENT_RULES automake option and AM_V_GEN.v2

Updated patch against current master
Comment 14 Jonny Lamb 2010-01-17 21:57:42 UTC
(In reply to comment #13)
> Updated patch against current master

Well, there are still some very verbose parts of the build (msgfmt, intltool and xml2po), but I guess this is the best we can do for now.

I edited your patch to suppress even more output and pushed it.