After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585010 - Port TidyGrid to Clutter-1.0 API
Port TidyGrid to Clutter-1.0 API
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-06 16:56 UTC by Owen Taylor
Modified: 2009-06-08 21:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port TidyGrid to Clutter-1.0 API (15.06 KB, patch)
2009-06-06 16:56 UTC, Owen Taylor 		reviewed Details | Review

Description Owen Taylor 2009-06-06 16:56:06 UTC 
- ClutterUnit is now replaced with float
- allocate() now takes flags rather than absolute_origin_changed boolean
Comment 1 Owen Taylor 2009-06-06 16:56:09 UTC 
Created attachment 136060 [details] [review]
Port TidyGrid to Clutter-1.0 API
Comment 2 Dan Winship 2009-06-07 00:49:43 UTC 
everything there looks right, though as with the mutter change, maybe some constants should be changed from ints to floats: in the row-gap and column-gap paramspecs, and the default natural_width and natural_height in tidy_grid_get_preferred_{width,height}.
Comment 3 Owen Taylor 2009-06-08 21:16:53 UTC 
Pushed, changing the constants to floating-point.