[forwarding from http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=531892]

Hi,

When sending an empty file using bluetooth-sendto, I get the following Gtk-CRITICAL messages:

% touch empty.txt
% bluetooth-sendto empty.txt

(bluetooth-sendto:5848): Gtk-CRITICAL **: gtk_progress_set_percentage: assertion `percentage >= 0 && percentage <= 1.0' failed

(bluetooth-sendto:5848): Gtk-CRITICAL **: gtk_progress_set_percentage: assertion `percentage >= 0 && percentage <= 1.0' failed


After some investigation, I suspect that the following code has a possible "divide by zero" problem.

gnome-bluetooth-2.27.5/sendto/main.c:
static void transfer_progress(DBusGProxy *proxy,
                                        guint64 bytes, gpointer user_data)
{
...
        current_sent = total_sent + bytes;
        fraction = (gdouble) current_sent / (gdouble) total_size; <<==
        gtk_progress_bar_set_fraction(GTK_PROGRESS_BAR(progress), fraction);

Note that total_size will be 0 if the file size is 0.


I suggest the following patch to fix the problem.

--- gnome-bluetooth-2.27.5.orig/sendto/main.c   2009-04-17 21:39:23.000000000 +0900
+++ gnome-bluetooth-2.27.5/sendto/main.c        2009-06-05 03:57:17.000000000 +0900
@@ -299,7 +299,10 @@
        gchar *time, *rate, *file, *text;

        current_sent = total_sent + bytes;
-       fraction = (gdouble) current_sent / (gdouble) total_size;
+       if (total_size == 0)
+               fraction = 1.0;
+       else
+               fraction = (gdouble) current_sent / (gdouble) total_size;
        gtk_progress_bar_set_fraction(GTK_PROGRESS_BAR(progress), fraction);

        current_time = get_system_time();


Regards,