After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584543 - Empathy doesn't properly manage a Geoclue restart
Empathy doesn't properly manage a Geoclue restart
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Geolocation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-01 20:17 UTC by Guillaume Desmottes
Modified: 2012-08-26 05:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed fix on branch fix-584543 http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-584543 This patch depends on http://bugs.freedesktop.org/show_bug.cgi?id=23425 on Geoclue (1.87 KB, patch)
2009-08-20 19:05 UTC, Pierre-Luc Beaudoin
reviewed Details | Review

Description Guillaume Desmottes 2009-06-01 20:17:22 UTC
To reproduce:
- Launch Geoclue manually
- Start Empathy and enable "publish location"
- Empathy communicates with your Geoclue instance as expected
- Disable "publish location"
- Restart Geoclue
- Enable "publish location". Empathy can't use Geoclue anymore:

** (empathy:10658): DEBUG: initial_address_cb: Error: Method "GetAddress" with signature "" on interface "org.freedesktop.Geoclue.Address" doesn't exist
** (empathy:10658): DEBUG: initial_position_cb: Error: Method "GetPosition" with signature "" on interface "org.freedesktop.Geoclue.Position" doesn't exist
Comment 1 Pierre-Luc Beaudoin 2009-08-20 18:56:21 UTC
I sent a patch to Geoclue where the GeoclueMasterClient should send an "invalidated" signal when the dbus service dies.  Empathy can then recreate one with its settings (and restart Geoclue at the same time).
Comment 2 Pierre-Luc Beaudoin 2009-08-20 18:56:33 UTC
See http://bugs.freedesktop.org/show_bug.cgi?id=23425
Comment 3 Pierre-Luc Beaudoin 2009-08-20 19:05:09 UTC
Created attachment 141276 [details] [review]
Proposed fix on branch fix-584543 http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-584543 This patch depends on http://bugs.freedesktop.org/show_bug.cgi?id=23425 on Geoclue

 libempathy-gtk/empathy-location-manager.c |   22 ++++++++++++++++++++--
 1 files changed, 20 insertions(+), 2 deletions(-)
Comment 4 Guillaume Desmottes 2009-08-21 16:12:45 UTC
Your patch looks good. Feel free to merge it once the Geoclue bits has been released (don't forget to bump the dep).
Comment 5 Pierre-Luc Beaudoin 2009-08-24 14:39:03 UTC
The patch has been merged in Geoclue, not released yet.
Comment 6 Jean-François Fortin Tam 2012-08-26 05:46:22 UTC
I have a vague feeling that geoclue has been released since then.