After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584312 - Totem does not ignore text files when adding to queue
Totem does not ignore text files when adding to queue
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
2.26.x
Other Linux
: Normal minor
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-05-30 18:25 UTC by Kamil Páral
Modified: 2009-08-04 22:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
bug demonstration (172.21 KB, image/png)
2009-05-30 18:25 UTC, Kamil Páral
Details

Description Kamil Páral 2009-05-30 18:25:17 UTC
I use Totem to very easily play some music album. I just drag and drop a folder onto Totem window. All the music files in the folder are added to the queue and played. That's great. BUT the folders very often contain some additional files (like pictures with album covers and text files with album information). The picture files are correctly ignored and not added to the queue (how can you play a picture?). But the text files are not ignored and *are* added to the queue (how can you play a text file?). When the queue playback comes to the text file, the whole playback is stopped and Totem displays an error dialog: it can't play a text file - obviously. This drives me mad. Please fix this.

See the screenshot, there is the error dialog and console error message.

Solution #1: Don't add non-media files to the queue (I have seen it happen for .txt and .desktop files).
Solution #2: Ignore non-media files in the queue, just skip them. Don't force users to approve error dialog and resume the playback everytime.

Thanks!
Comment 1 Kamil Páral 2009-05-30 18:25:43 UTC
Created attachment 135633 [details]
bug demonstration
Comment 2 Philip Withnall 2009-05-30 21:42:20 UTC
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 303942 ***
Comment 3 Bastien Nocera 2009-07-31 16:35:31 UTC
> Please fix this.

Don't ever add something like this to bugs again. Makes us want to ignore the bug rather than fix it.
Comment 4 Bastien Nocera 2009-07-31 16:41:06 UTC
commit 73db4d176c48deec762dc042befab4b0a4bda5ab
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Jul 31 17:36:09 2009 +0100

    Bug 584312 – Totem does not ignore text files when adding to queue
    
    Ignore dual-types that are still text/plain after data check.
    Before that, this only happened if we didn't have data for the
    file yet, but we're certain we do now, so we can gently ignore.
Comment 5 Kamil Páral 2009-08-04 20:56:27 UTC
>> Please fix this.
>Don't ever add something like this to bugs again.
>Makes us want to ignore the bug rather than fix it.

I don't really want to argue and thank you for fixing the bug, but I don't really understand why are you angry over me asking you politely. I don't know about your country, but in my country it is polite to be polite. So I don't really get it from end-user view nor developer view (I have my own project). Maybe it's just a slight cultural difference.

Thanks again.
Comment 6 Philip Withnall 2009-08-04 22:06:01 UTC
(In reply to comment #5)
> I don't really want to argue and thank you for fixing the bug, but I don't
> really understand why are you angry over me asking you politely. I don't know
> about your country, but in my country it is polite to be polite. So I don't
> really get it from end-user view nor developer view (I have my own project).
> Maybe it's just a slight cultural difference.

It's frustrating to get many people filing many different bugs, many of which are complete rubbish (though not this one), all saying that theirs is the most important and should be fixed immediately. It can sometimes result in outbursts from developers. ;-)