GNOME Bugzilla – Bug 584164
gstspu-pgs.c warnings for format string args and uninitialized vars
Last modified: 2009-05-28 22:12:54 UTC
Please describe the problem: warnings are: gstspu-pgs.c: In function ‘parse_presentation_segment’: gstspu-pgs.c:438: warning: format ‘%li’ expects type ‘long int’, but argument 8 has type ‘int’ gstspu-pgs.c: In function ‘parse_set_palette’: gstspu-pgs.c:499: warning: format ‘%li’ expects type ‘long int’, but argument 8 has type ‘int’ gstspu-pgs.c: In function ‘parse_set_window’: gstspu-pgs.c:534: warning: format ‘%li’ expects type ‘long int’, but argument 8 has type ‘int’ gstspu-pgs.c: In function ‘parse_set_object_data’: gstspu-pgs.c:596: warning: format ‘%li’ expects type ‘long int’, but argument 8 has type ‘int’ gstspu-pgs.c: In function ‘gstspu_pgs_render’: gstspu-pgs.c:222: warning: ‘run_len’ may be used uninitialized in this function gstspu-pgs.c: In function ‘gstspu_pgs_execute_event’: gstspu-pgs.c:99: warning: ‘run_len’ may be used uninitialized in this function Steps to reproduce: build gst-plugins-bad Actual results: Expected results: Does this happen every time? Other information:
Created attachment 135524 [details] [review] patch which fixes warnings with casts and initializing vars to 0
Created attachment 135530 [details] [review] fixed warnings by casting error msg arguments and initializing run_len in the default case
Thanks, committed: commit 530377c40f1586378b1fc34be4b5f99b92108078 Author: Tristan Matthews <le.businessman@gmail.com> Date: Thu May 28 23:08:17 2009 +0100 gstspu: Fix compiler warnings on OS/X Fix some warnings for format string args and uninitialized vars on OS/X Fixes: #584164 Signed-off-by: Jan Schmidt <thaytan@noraisin.net>