GNOME Bugzilla – Bug 584030
[Mail-To-Task] improve duplicate handling and such
Last modified: 2013-09-13 01:04:24 UTC
This is not about duplicate handling only, it's about more things, as discussed with Chen on IRC. It's proposed to: a) rename "Convert to a*" to "Create a*" b) preselect default source in the source selector c) before creating event, check for duplicates, if it's there, ask user whether he/she wants to open already stored even there, or create a new event of the chosen type (the already created event can be of a different type). d) finally open the editor before posting event to the calendar, for possible changes user wants to do in the event. Not sure if d) might be configurable, as for someone that can be boring to review, but will see. Maybe adding a checkbox to the source selector, "Open event in an editor before storing"...
Nice usability improvements!
Chen suggested, credits to him :)
Milan, thanks for filing it :) I was just thinking about some more things. Would it be better to only open the editors while creating meetings/assigned tasks. As these would send a mail to the recipients, it would be better to show them in the editor for reviewing the details. And should we allow selecting only one mail at a time for meetings/assigned tasks ? It would not be good to open up three or four editors if many mails are selected. I guess current behavior can be left the same way for converting to appointments/tasks.
Created attachment 135491 [details] [review] proposed eds patch for evolution-data-server; Little extension to ESourceSelectorDialog to make life easier.
Created attachment 135492 [details] [review] proposed evo patch for evolution; After re-discussed with Chen, also changed: d) open editor only for meetings e) meeting can be created for one selected mail only, not for multiselected f) create tasks as not assigned Couple new texts, feel free to re-word.
(In reply to comment #4) > Little extension to ESourceSelectorDialog to make life easier. I like that. I could use that for kill-bonobo. Small enhancement might be to return the default ESource (or NULL if there was none), so you can both get and select it in one step. Marking as approved either way. The second patch I don't have time to review just yet.
Created commit ab2c4ce in eds master, slightly modified to return gboolean, whether found any default source in the given source list.
open_component_editor - not apt to put this function inside itip-utils.c as it serves for a different purpose. I tried to find a right file to insert this, but could not find any. Prolly create a new one ? open_component_editor need not get the object again from the backend and can be used just to open the component. As mc->stored_comp already has it and can be re-used. Keeping error messages in errors.xml and using e_error_run would be good. Please break-down the functions in smaller ones. eg. the switch case for getting the error strings can be put in a utility function. If a user selects a mail and converts it for the second time, do we generate a new uid for the component and show it in the editor ?
Created attachment 139560 [details] [review] proposed evo patch ][ for evolution; Contains most of the things mentioned above. The error.xml I gave up, it doesn't seem to know ngettext. I also fixed a memory leak with 'msg' in the previous patch, and broke strings into functions. With respect of generating new uid-s it was there, but only for non-meetings, I added for meeting too, ensuring the RID will be removed too.
Please commit the patch. I have not tested it, but changes are ok. If I see any issues while testing, will provide comments later. Please announce the string/ui changes.
Created commit a03f926 in evo master (2.27.90+)