GNOME Bugzilla – Bug 583756
Always shows system connections as last used "never" even after using them
Last modified: 2010-11-03 15:17:28 UTC
Please describe the problem: Even after connecting via a system connection, the connection editor shows "never" next to the connection, rather than remembering how long agin the connection last worked. (In case it matters, the connection in question uses WEP.) Steps to reproduce: 1. Set up a system connection. 2. Connect to it. 3. Open the connection editor. 4. Look at system connection. Actual results: The column showing the last connection time shows "never". Expected results: The column showing the last connection time should show the last connection time. Does this happen every time? Yes. Other information:
(Originally reported as Debian bug 509817: http://bugs.debian.org/509817 )
I can confirm that for the "Auth eth0" connection that gets created automatically. Manually configured connections, such as wifi or 3G, have this field correctly. Presumably this is because there is no entry for "Auto eth0" in /system/networking/connections/*, since it is an implicit and fully automatic connection without any configuration? This also not only affects system connections, but also the (default) per-user eth0 connection.
Created attachment 171505 [details] [review] Don't show automatic eth connections as "never used" This adds a current timestamp to the default wired connection object on creation. With that, connection editor now shows the "Auto eth0" style connections as "last used: now" instead of "never". It could be disputed that the property should be set in nm_sysconfig_settings_device_added() instead, please let me know if you would prefer that. I just think that "now" is a sensible default timestamp for newly created connection objects.
Created attachment 171506 [details] [review] fix compilation with dhcp3 While building git head, I noticed a trivial "use-before-initialize" bug which caused a build failure. Trivial patch attached. I hope it's okay to smuggle it in here, instead of opening a new bug for this, but if you prefer that, please let me know. Thanks!
DHCP3 patch is: 61e86600d5ed2d5e3721074ec68e289c93fe67cc (master) 42431e63c41e495d6550482a14e908d619c41809 (0.8.x)
timestamp for default auto wired is: febb3d2cb460e28b42fc3abeeaaa5b9fc94fde81 (master) 5ba3122cdcbfe7c56f3f196bab1e290290744ed2 (0.8.x)
Created attachment 172683 [details] [review] Update timestamps for system connections Updating timestamps for system connections.
Both patches (martin's and jklimes') look good, please commit.
Comment on attachment 171505 [details] [review] Don't show automatic eth connections as "never used" My two were already committed, updating status.
patch from comment #7 committed: 607350294d6efff579220baba61e8e63b135cf03 (master) 5e54122f4c243a4df64c9d3804d0a08f5a1e3a8e (NM_0_8) Martin's patches already there per comments #5 and #6