Bug 583432 – importer hangs when importing a clip with subtitles

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 583432 - importer hangs when importing a clip with subtitles


Summary:	importer hangs when importing a clip with subtitles


Status:	RESOLVED FIXED

Product:	pitivi
Classification:	Other
Component:	General
Version:	Git
Hardware:	Other Linux

Importance:	Normal blocker
Target Milestone:	0.13.1
Assigned To:	Alessandro Decina
QA Contact:	Pitivi maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-05-21 11:08 UTC by Wim Taymans
Modified:	2009-05-21 16:43 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Fix text support (923 bytes, patch) 2009-05-21 11:56 UTC, Edward Hervey	reviewed	Details \| Review
fix (2.54 KB, patch) 2009-05-21 13:37 UTC, Alessandro Decina	accepted-commit_now	Details \| Review

Description Wim Taymans 2009-05-21 11:08:55 UTC

When I (apparently) try to import a clip with embedded subtitles the importer gives this stacktrace and keeps on spinning:

Traceback (most recent call last):

+ Trace 215631

File "pitivi/discoverer.py", line 342 in _busMessageEosCb
```
self._finishAnalysis()
```
File "pitivi/discoverer.py", line 215 in _finishAnalysis
```
self.emit('discovery-done', self.current_uri, factory)
```
File "pitivi/signalinterface.py", line 145 in emit
```
*args, **kwargs)
```
File "pitivi/signalinterface.py", line 119 in emit
```
res = cb(*ar, **kw)
```
File "pitivi/sourcelist.py", line 175 in _discoveryDoneCb
```
self.addFactory(factory.name, factory)
```
File "pitivi/sourcelist.py", line 157 in addFactory
```
self.emit("file_added", factory)
```
File "pitivi/signalinterface.py", line 145 in emit
```
*args, **kwargs)
```
File "pitivi/signalinterface.py", line 119 in emit
```
res = cb(*ar, **kw)
```
File "pitivi/ui/sourcelist.py", line 475 in _fileAddedCb
```
self._addFactory(factory)
```
File "pitivi/ui/sourcelist.py", line 465 in _addFactory
```
beautify_factory(factory),
```
File "pitivi/ui/sourcelist.py", line 122 in beautify_factory
```
streams.sort(key=stream_sort_key)
```
File "pitivi/ui/sourcelist.py", line 119 in stream_sort_key
```
return ranks[type(stream)]
```

KeyError: <class 'pitivi.stream.TextStream'>

Comment 1 Edward Hervey 2009-05-21 11:56:11 UTC

Created attachment 135083 [details] [review]
Fix text support

Wim, could you try this patch ?

Comment 2 Wim Taymans 2009-05-21 12:00:35 UTC

this patch works, but putting the media to the timeline now gives this series of stacktraces when hovegin over the timeline:

 ERROR [26775] [0x7fca38f606f0] "<Timeline at 0x2c35c50>"        timeline          May 21 13:59:24      _errorObject: Couldn't find a complete stream mapping (self:2 < factory:3) (pitivi/log/loggable.py:30)
Traceback (most recent call last):

+ Trace 215634

File "pitivi/ui/timeline.py", line 287 in _dragMotionCb
```
self._add_temp_source()
```
File "pitivi/ui/timeline.py", line 330 in _add_temp_source
```
for factory in self._factories]
```
File "pitivi/timeline/timeline.py", line 578 in addSourceFactory
```
raise TimelineError() pitivi.timeline.timeline.TimelineError
```

Comment 3 Alessandro Decina 2009-05-21 13:37:27 UTC

Created attachment 135095 [details] [review]
fix

Comment 4 Edward Hervey 2009-05-21 14:19:39 UTC

The ui/sourcelist.py code should stay the same as in my original patch (i.e. if it's not one of the know stream types, bump it to 2).

Apart from that it's ok for me.

Comment 5 Alessandro Decina 2009-05-21 16:37:50 UTC

commit 9c2e2f98bb66c7362111075f1274aeb2c22fbc24
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Thu May 21 17:52:58 2009 +0200

    Allow importing multi-audio or multi-video clips.
    
    Be less strict in mapping streams to tracks for now, adding the first stream
    each kind to the timeline.