After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583388 - export_print_page in ev-print-operation.c has a logic bug
export_print_page in ev-print-operation.c has a logic bug
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: printing
2.26.x
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-20 23:28 UTC by Bartek Kostrzewa
Modified: 2009-05-23 15:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Description Bartek Kostrzewa 2009-05-20 23:28:43 UTC 
Please describe the problem:
export_print_page in ev-print-operation.c: (line 905 in my source, 955 in the master trunk)

(export->pages_per_sheet > 1 &&
export->total - 1 % export->pages_per_sheet == 0)

will always be false because there's parantheses missing around (export->total - 1)

Funnily enough, fixing the bug seems to break the intended behaviour :)

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Carlos Garcia Campos 2009-05-23 15:24:56 UTC 
Fixed by the patch attached to bug #583429.