After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583321 - QNX: no SA_RESTART
QNX: no SA_RESTART
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
2.36.x
Other other
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2009-05-20 11:23 UTC by Thomas Klausner
Modified: 2013-09-27 16:16 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8

Attachments
trivial fix (871 bytes, patch)
2013-04-13 10:37 UTC, Patrick Welche 		none Details | Review
trivial build fix (912 bytes, patch)
2013-09-27 09:13 UTC, Patrick Welche 		accepted-commit_now Details | Review

Description Thomas Klausner 2009-05-20 11:23:39 UTC 
QNX is lacking SA_RESTART; "#define SA_RESTART 0" seems to work fine.
This affects glib/gtester.c and glib/gmain.c.
Configure or the two files should check for the definition.
Comment 1 Patrick Welche 2012-01-12 16:48:03 UTC 
Funny how history repeats itself:

Bug 168352 got rid of SA_RESTART as hpux wasn't happy with it
Bug 651725 cleaned the spaghetti up and put it back

and here we are with

http://community.qnx.com/sf/discussion/do/listPosts/projects.core_os/discussion.newcode.topc8501?_pagenum=2

saying QNX hasn't got SA_RESTART...

Implement a safe_read() function which wraps read() in a while loop testing for EINTR? or not bother?
Comment 2 Patrick Welche 2013-04-13 10:37:19 UTC 
Created attachment 241440 [details] [review]
trivial fix

Trivial fix: only use SA_RESTART if it is defined
Comment 3 Patrick Welche 2013-09-27 09:13:47 UTC 
Created attachment 255904 [details] [review]
trivial build fix

Update to remove fuzz on patch application.

(Have I waited long enough to apply?)
Comment 4 Colin Walters 2013-09-27 12:11:20 UTC 
Review of attachment 255904 [details] [review]:

Looks fine.
Comment 5 Patrick Welche 2013-09-27 16:16:42 UTC 
Commited thanks! (faster than a year and a half..)