After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583305 - gtk_init_with_args() arguments should be const gchar*
gtk_init_with_args() arguments should be const gchar*
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.18.x
Other All
: Normal trivial
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-05-20 08:47 UTC by Nick Schermer
Modified: 2009-10-26 21:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make translation_domain const (426 bytes, patch)
2009-05-20 15:14 UTC, Nick Schermer 		none Details | Review
Same as previous patch but including header (912 bytes, patch)
2009-05-20 15:19 UTC, Nick Schermer 		none Details | Review
Including parameter_string (1.08 KB, patch)
2009-05-26 21:23 UTC, Nick Schermer 		committed Details | Review

Description Nick Schermer 2009-05-20 08:47:08 UTC 
Please describe the problem:
The translation_domain argument should be const gchar * to allow compilation with -Wwrite-strings. It only passes the argument to g_option_context_add_main_entries() which is already const gchar*.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
See also bug #570367 and #565665 for similar problems.
Comment 1 Nick Schermer 2009-05-20 15:14:39 UTC 
Created attachment 135032 [details] [review]
Make translation_domain const
Comment 2 Nick Schermer 2009-05-20 15:19:26 UTC 
Created attachment 135033 [details] [review]
Same as previous patch but including header
Comment 3 Matthew Barnes 2009-05-26 20:38:51 UTC 
Same goes for the "parameter_string" argument.
Comment 4 Nick Schermer 2009-05-26 21:23:28 UTC 
Created attachment 135407 [details] [review]
Including parameter_string
Comment 5 Christian Dywan 2009-09-18 16:33:48 UTC 
Looks like the right thing to me.
Comment 6 Emmanuele Bassi (:ebassi) 2009-10-26 16:28:22 UTC 
given that we've been doing const-ification of parameters for quite some time, now, looks perfectly good to commit.
Comment 7 Javier Jardón (IRC: jjardon) 2009-10-26 21:30:13 UTC 
Comment on attachment 135407 [details] [review]
Including parameter_string

commit 92a68f4cf94f7615b5f0b2d16ec3c20b3775202b
Comment 8 Javier Jardón (IRC: jjardon) 2009-10-26 21:30:26 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.