After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583281 - Unportable test(1) construct in configure script
Unportable test(1) construct in configure script
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
2.26.x
Other NetBSD
: Normal normal
: 2.26.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2009-05-19 23:19 UTC by Thomas Klausner
Modified: 2009-05-21 16:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
configure patch (1.04 KB, patch)
2009-05-19 23:20 UTC, Thomas Klausner 		none Details | Review
Patch against configure.in so it can be applied directly. (1.56 KB, patch)
2009-05-21 10:50 UTC, Thomas Klausner 		committed Details | Review

Description Thomas Klausner 2009-05-19 23:19:41 UTC 
The configure script uses the unportable bash "=="
comparison operator for test(1). It is not supported by most other shells or
even test(1) from GNU coreutils. Please use "=" instead.
                                                                                                                                  
I'll attach a patch against configure and leave the patch against
configure.{in.ac} as an example for the reader ;)
Comment 1 Thomas Klausner 2009-05-19 23:20:18 UTC 
Created attachment 134992 [details] [review]
configure patch
Comment 2 Thomas Klausner 2009-05-21 10:50:55 UTC 
Created attachment 135082 [details] [review]
Patch against configure.in so it can be applied directly.
Comment 3 Adam Schreiber 2009-05-21 16:55:50 UTC 
Committed.  Thanks.

commit 6eda8ecc06e4e114e5ebe8b8817e57363aad5287
Author: Thomas Klausner <wiz@danbala.tuwien.ac.at>
Date:   Thu May 21 12:53:08 2009 -0400

    Bug 583281 – Unportable test(1) construct in configure script
    
    Change == tests to = tests