GNOME Bugzilla – Bug 583273
add padding around status icons
Last modified: 2011-02-22 23:52:09 UTC
Some status area implementations (most importantly the GNOME one) add a few pixels of padding around the socket that the status icon is added to. This is done mainly so that the icon image itself doesn't contact the edge of the screen or the adjacent widgets. One of the big downsides to this approach is that the active clickable area for the status icon cannot extend to the edge of the screen and therefore we lose out on one aspect of Fitt's Law. So, one option (suggested by Owen) is to move some of this padding into the icon itself.
Looks fine to me; should probably themable in some fashion.
Created attachment 145717 [details] [review] a patch Here is a patch that adds padding in the GtkImage. The amount of padding is determined by reading a _NET_SYSTEM_TRAY_PADDING property off the manager window, in the same way that orientation and visual are obtained.
Created attachment 145718 [details] [review] corresponding patch for the notification-area-applet The corresponding patch for the tray.
I've rebased and merged the gtk parts into git master (2.90...) Now, the gnome-panel parts need to be pushed upstream.
reassigning this to gnome-panel since there's a patch here, and not in the corresponding panel bug
*** Bug 140764 has been marked as a duplicate of this bug. ***
*** Bug 621341 has been marked as a duplicate of this bug. ***
I've fixed this based on the patch, but without gconf: the padding can be set in the theme, like this: NaTrayApplet { -NaTrayApplet-icon-padding: 6; }
Comment on attachment 145718 [details] [review] corresponding patch for the notification-area-applet Committed a modified version of this.