After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583175 - automatic borders or toolbar misbehaviour?
automatic borders or toolbar misbehaviour?
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2009-05-19 08:01 UTC by Andreas J. Guelzow
Modified: 2010-04-27 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
implement a new signal for the pixmaps combo action. (1.66 KB, patch)
2010-03-19 14:35 UTC, Jean Bréfort 		none Details | Review
the gnumeric side patch (451 bytes, patch)
2010-03-19 14:36 UTC, Jean Bréfort 		none Details | Review
updated goffice patch (3.02 KB, patch)
2010-03-27 08:28 UTC, Jean Bréfort 		committed Details | Review
update gnumeric patch (1.48 KB, patch)
2010-03-27 08:30 UTC, Jean Bréfort 		committed Details | Review

Description Andreas J. Guelzow 2009-05-19 08:01:00 UTC 
new gnumeric
select A2
use the toolbar to change the background color to white

note that A2 now also has a left border.

This does not happen if you use the format dialog. Note that there is a "set border" on the undo menu!
Comment 1 Andreas J. Guelzow 2009-05-19 14:10:55 UTC 
More info:

The "background colour" item is off the right edge of the window so to get there I have to open that extension menu located at the edge. Breaking into  cb_border_activated shows that it get's triggered when the cursor moves across it to background item. (That also freezes X so badly, that if this is you only display you would need to reboot.)

I suspect that this may be a new gtk enhancement. (I am running gtk from git as of 2 weeks ago or so)
Comment 2 Andreas J. Guelzow 2009-05-19 14:32:36 UTC 
I downgraded (?) gtk to whatever is distributed with debian sid these days and obeserve the same problem, eve with gnumeric as distributed with debian sid. (release 1.9.7).
Comment 3 Morten Welinder 2009-05-29 15:55:20 UTC 
For the record, I cannot reproduce here.  Jean seems to see it.
A stack trace at cb_border_activated would likely be useful.
Comment 4 Andreas J. Guelzow 2009-05-29 18:10:33 UTC 



+
Trace
    215765






    

  • 
#0
cb_border_activated

    
                at wbc-gtk.c
                  line
                  2547

    

    • 

  • 
#1
IA__g_closure_invoke

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gclosure.c
                  line
                  767

    

    • 

  • 
#2
signal_emit_unlocked_R

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  3247

    

    • 

  • 
#3
IA__g_signal_emit_valist

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  2980

    

    • 

  • 
#4
IA__g_signal_emit

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  3037

    

    • 

  • 
#5
??

    
                from
                /usr/lib/libgtk-x11-2.0.so.0

    

    • 

  • 
#6
IA__g_closure_invoke

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gclosure.c
                  line
                  767

    

    • 

  • 
#7
signal_emit_unlocked_R

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  3177

    

    • 

  • 
#8
IA__g_signal_emit_valist

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  2980

    

    • 

  • 
#9
IA__g_signal_emit

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  3037

    

    • 

  • 
#10
gtk_widget_activate

    
                from
                /usr/lib/libgtk-x11-2.0.so.0

    

    • 

  • 
#11
??

    
                from
                /usr/lib/libgtk-x11-2.0.so.0

    

    • 

  • 
#12
??

    
                from
                /usr/lib/libgtk-x11-2.0.so.0

    

    • 

  • 
#13
??

    
                from
                /usr/lib/libgtk-x11-2.0.so.0

    

    • 

  • 
#14
IA__g_closure_invoke

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gclosure.c
                  line
                  767

    

    • 

  • 
#15
signal_emit_unlocked_R

    • 

  • 
#16
IA__g_signal_emit_valist

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  2990

    

    • 

  • 
#17
IA__g_signal_emit

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  3037

    

    • 

  • 
#18
??

    
                from
                /usr/lib/libgtk-x11-2.0.so.0

    

    • 

  • 
#19
??

    
                from
                /usr/lib/libgtk-x11-2.0.so.0

    

    • 

  • 
#20
IA__g_closure_invoke

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gclosure.c
                  line
                  767

    

    • 

  • 
#21
signal_emit_unlocked_R

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  3285

    

    • 

  • 
#22
IA__g_signal_emit_valist

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  2990

    

    • 

  • 
#23
IA__g_signal_emit

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  3037

    

    • 

  • 
#24
??

    
                from
                /usr/lib/libgtk-x11-2.0.so.0

    

    • 

  • 
#25
gtk_main_do_event

    
                from
                /usr/lib/libgtk-x11-2.0.so.0

    

    • 

  • 
#26
??

    
                from
                /usr/lib/libgdk-x11-2.0.so.0

    

    • 

  • 
#27
IA__g_main_context_dispatch

    
                at /tmp/buildd/glib2.0-2.20.1/glib/gmain.c
                  line
                  1814

    

    • 

  • 
#28
g_main_context_iterate

    
                at /tmp/buildd/glib2.0-2.20.1/glib/gmain.c
                  line
                  2448

    

    • 

  • 
#29
IA__g_main_loop_run

    
                at /tmp/buildd/glib2.0-2.20.1/glib/gmain.c
                  line
                  2656

    

    • 

  • 
#30
gtk_main

    
                from
                /usr/lib/libgtk-x11-2.0.so.0

    

    • 

  • 
#31
main

    
                at main-application.c
                  line
                  450

    

    • 













Comment 5


Andreas J. Guelzow





          2009-05-29 18:59:15 UTC
        



A slightly better backtrace:





+
Trace
    215766






    

  • 
#0
cb_border_activated

    
                at wbc-gtk.c
                  line
                  2547

    

    • 

  • 
#1
IA__g_closure_invoke

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gclosure.c
                  line
                  767

    

    • 

  • 
#2
signal_emit_unlocked_R

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  3247

    

    • 

  • 
#3
IA__g_signal_emit_valist

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  2980

    

    • 

  • 
#4
IA__g_signal_emit

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  3037

    

    • 

  • 
#5
_gtk_action_emit_activate

    
                at /scratch/build-area/gtk+2.0-2.16.1/gtk/gtkaction.c
                  line
                  727

    

    • 

  • 
#6
IA__g_closure_invoke

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gclosure.c
                  line
                  767

    

    • 

  • 
#7
signal_emit_unlocked_R

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  3177

    

    • 

  • 
#8
IA__g_signal_emit_valist

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  2980

    

    • 

  • 
#9
IA__g_signal_emit

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gsignal.c
                  line
                  3037

    

    • 

  • 
#10
IA__gtk_widget_activate

    
                at /scratch/build-area/gtk+2.0-2.16.1/gtk/gtkwidget.c
                  line
                  4792

    

    • 

  • 
#11
gtk_menu_shell_enter_notify

    
                at /scratch/build-area/gtk+2.0-2.16.1/gtk/gtkmenushell.c
                  line
                  830

    

    • 

  • 
#12
gtk_menu_enter_notify

    
                at /scratch/build-area/gtk+2.0-2.16.1/gtk/gtkmenu.c
                  line
                  3833

    

    • 

  • 
#13
_gtk_marshal_BOOLEAN__BOXED

    
                at /scratch/build-area/gtk+2.0-2.16.1/gtk/gtkmarshalers.c
                  line
                  84

    

    • 

  • 
#14
IA__g_closure_invoke

    
                at /tmp/buildd/glib2.0-2.20.1/gobject/gclosure.c
                  line
                  767

    

    • 













Comment 6


frob





          2010-03-19 13:45:05 UTC
        



Reproduced in 1.10. Also happens if you change foreground color with toolbar button. It seems to apply last used border style to the cell.






Comment 7


Jean Bréfort





          2010-03-19 14:35:58 UTC
        



Created attachment 156557 [details] [review]
implement a new signal for the pixmaps combo action.

We also need the equivalent for the color combo






Comment 8


Jean Bréfort





          2010-03-19 14:36:28 UTC
        



Created attachment 156558 [details] [review]
the gnumeric side patch






Comment 9


Morten Welinder





          2010-03-20 22:59:38 UTC
        



Can we call the signal something like combo-activate?  That way we can
use the same name for the other widgets that will need it.

I don't see how we can avoid going this way.  I don't like it, though.

BTW: Gnumeric will need a configure.in update.






Comment 10


Jean Bréfort





          2010-03-27 08:16:54 UTC
        



OK for the combo-activate signal, but it still need to be implemented in each file. Looks like test and stack combo work and don't need this signal, unless I missed something when testing.






Comment 11


Jean Bréfort





          2010-03-27 08:28:24 UTC
        



Created attachment 157257 [details] [review]
updated goffice patch






Comment 12


Jean Bréfort





          2010-03-27 08:30:02 UTC
        



Created attachment 157258 [details] [review]
update gnumeric patch






Comment 13


Jean Bréfort





          2010-04-27 15:51:05 UTC
        



This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.