GNOME Bugzilla – Bug 582784
Get rid of deprecated libgnome(ui)
Last modified: 2009-06-03 13:22:16 UTC
GNOME 3 will not ship libgnome/ui anymore. See http://live.gnome.org/LibgnomeMustDie . For the status of your module see the automatic statistics at http://www.gnome.org/~fpeters/299.html (updated every two hours). $:andre\> cd gtkhtml/ $:andre\> grep -r libgnome . ./README:In order to compile GtkHTML, you need libgnome[ui] 1.112.1 (or later), ./components/editor/gtkhtml-editor-signals.c: #include <libgnome/gnome-url.h> ./configure.in: m4_define([libgnomeui_minimum_version], [2.0.0]) ./configure.in: GTKHTML_MODULES="gtk+-2.0 >= gtk_minimum_version libgnomeui-2.0 >= libgnomeui_minimum_version libglade-2.0 >= libglade_minimum_version enchant gconf-2.0 iso-codes" ./gtkhtml/gtkhtml.c: #include <libgnome/gnome-util.h> ./gtkhtml/dllmain.c: #include <libgnome/gnome-init.h> ./gtkhtml/htmlengine.c: #include <libgnomeui/gnome-dialog-util.h> ./gtkhtml/test.c: #include <libgnomeui/gnome-ui-init.h>
Created attachment 135419 [details] [review] Delete depends from gnomeui Also replace static tests list to auto generated tests list based on code from gtest(test.c).
Thanks a lot for the patch! There are some string changes in there, are they really needed? For example from "Print pre_view" to "_Preview" if I get it right, but maybe I'm wrong (not a coder). - { GNOME_APP_UI_ITEM, N_("Print pre_view"), N_("Print preview"), + "_Preview", "<control>P", /* name, stock id */ + "Print Preview", /* tooltip */
Created attachment 135502 [details] [review] Revert to use old shortcut's It's have some sense. I revert changes shortcut.
Patch looks good. Committed with a few minor cleanups: http://git.gnome.org/cgit/gtkhtml/commit/?id=bcf04302751e46b377ca91c7cdd02dbce95d8929
Thanks a lot for contributing this patch! http://www.gnome.org/~fpeters/299.html updated.
Hmm, now I realize that this bug also covered libgnome: :-P ./components/editor/gtkhtml-editor-signals.c: #include <libgnome/gnome-url.h> ./gtkhtml/gtkhtml.c: #include <libgnome/gnome-util.h> ./gtkhtml/dllmain.c: #include <libgnome/gnome-init.h> This stuff is not fixed yet... shall I reopen, or file a new separate libgnome ticket and update the wikipage + 299.html?
Only remaining case I see is dllmain.c, where it's calling gnome_win32_get_prefixes(). GLib's g_win32_get_package_installation_directory_of_module() gets you the DLL prefix, but I don't see another way to look up the code page prefix. Best hand this off to the Win32 guys.
OK, the gnome_win32_get_prefixes(...) takes a handle to an executable and returns the runtime prefix in both utf-8 and system code-page. The replacement should be to use g_win32_get_package_installation_directory_of_module() that takes the handle of the module and returns the prefix in utf-8 and then construct the system code-page encoded prefix using g_win32_locale_filename_from_utf8. Let me cook a patch.
Created attachment 135873 [details] [review] replacing the libgnome function by glib functions
(In reply to comment #9) > Created an attachment (id=135873) [edit] > replacing the libgnome function by glib functions When committing please also remove #include <libgnome/gnome-init.h>
Committed and removed the header too