After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582647 - don't use transparency in window selector
don't use transparency in window selector
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-14 19:00 UTC by William Jon McCann
Modified: 2009-05-20 21:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
simple patch (442 bytes, patch)
2009-05-20 20:23 UTC, William Jon McCann
none Details | Review
patch (842 bytes, patch)
2009-05-20 20:54 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2009-05-14 19:00:26 UTC
The goal of the workspace view is to identify and select windows.  Transparency results in the blending of the window and the background (and icons on the desktop).  I think the transparency is counterproductive.

We used it in the initial mockups kind of as a lark - it wasn't well thought out.
Comment 1 William Jon McCann 2009-05-20 20:23:32 UTC
Created attachment 135048 [details] [review]
simple patch
Comment 2 Owen Taylor 2009-05-20 20:32:45 UTC
Why don't you just remove WINDOW_OPACITY - we can always add it back, but if we aren't using it, it's clutter.

Otherwise the comment:
 
 // Windows are slightly translucent in the overlay mode
-const WINDOW_OPACITY = 0.9 * 255;
+const WINDOW_OPACITY = 1.0 * 255;

would certainly have to be changed :-)
Comment 3 William Jon McCann 2009-05-20 20:54:45 UTC
Created attachment 135051 [details] [review]
patch
Comment 4 Owen Taylor 2009-05-20 20:57:37 UTC
Looks good, please commit.
Comment 5 William Jon McCann 2009-05-20 21:39:46 UTC
commit 99e6004c6603e6a56ca21eef5220f5f7993eca67