After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582505 - Use GtkBuilder instead of libglade
Use GtkBuilder instead of libglade
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: Editing
3.27.x
Other Linux
: Normal normal
: ---
Assigned To: Srinivasa Ragavan
Srinivasa Ragavan
evolution[cleanup]
Depends on:
Blocks: 572883
 
 
Reported: 2009-05-13 17:38 UTC by André Klapper
Modified: 2009-06-29 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
delete depends from libglade (423.64 KB, patch)
2009-05-29 21:18 UTC, Denis Pauk
none Details | Review
fix gtkhtml/po/POTFILES.in (423.11 KB, patch)
2009-06-04 07:43 UTC, Denis Pauk
committed Details | Review

Description André Klapper 2009-05-13 17:38:32 UTC
According to http://www.gnome.org/~fpeters/299.html
this module depends on libglade.

In GNOME 2.27, libglade has been deprecated in favor of GtkBuilder. See
http://library.gnome.org/devel/gtk/stable/gtk-migrating-GtkBuilder.html for
migration instructions. Also see
http://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder
Comment 1 Denis Pauk 2009-05-29 21:18:16 UTC
Created attachment 135583 [details] [review]
delete depends from libglade

Please review patch. I test only with gtkhtml-editor-test and evolution - I think looks good. But please test it.
Comment 2 André Klapper 2009-06-03 11:31:00 UTC
> --- gtkhtml/po/POTFILES.in	2009-05-29 22:13:43.000000000 +0300
> +++ gtkhtml-new/po/POTFILES.in	2009-05-29 23:46:37.000000000 +0300
> @@ -11,7 +11,6 @@
>  components/editor/gtkhtml-editor-actions.c
>  components/editor/gtkhtml-editor-private.c
>  components/editor/gtkhtml-editor.c
> -components/editor/gtkhtml-editor.glade
>  components/editor/gtkhtml-face-chooser.c
>  components/editor/gtkhtml-spell-checker.c
>  components/editor/gtkhtml-spell-dialog.c

I'm missing a
+[type: gettext/glade]components/editor/gtkhtml-editor.builder.ui
Comment 3 Denis Pauk 2009-06-04 07:43:00 UTC
Created attachment 135922 [details] [review]
fix gtkhtml/po/POTFILES.in

Thank you, I fix it and update patch.
Comment 4 Matthew Barnes 2009-06-29 15:04:51 UTC
Looks great!  Builds without a warning, passes distcheck, and even works!

Only issue is the GLADE_CATALOG stuff needs to stay, since that's for Glade 3 (the application), not libglade (the library).  I took care of it.

Committed to master:
http://git.gnome.org/cgit/gtkhtml/commit/?id=7b4440c7ff786834ad943ccb21ef2d4d02c739e8