After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582484 - Take advantage of trayicon transparency in gtk+ 2.16
Take advantage of trayicon transparency in gtk+ 2.16
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-13 15:57 UTC by Dan Winship
Modified: 2009-07-17 17:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Take advantage of trayicon transparency in gtk+ 2.16 (2.30 KB, patch)
2009-05-13 15:57 UTC, Dan Winship
accepted-commit_now Details | Review

Description Dan Winship 2009-05-13 15:57:02 UTC
This changes the notification tray to be fully-transparent if you're
using gtk 2.16 or later. With earlier versions, it creates the round-
cornered box just like before.

This had been a leftover TODO from the original tray code, although I
know Owen has said that he likes the opaque box anyway, so maybe we
don't want this? (I like the transparent version better, modulo the
fact that I don't like the tranlucent panel :-)
Comment 1 Dan Winship 2009-05-13 15:57:05 UTC
Created attachment 134579 [details] [review]
Take advantage of trayicon transparency in gtk+ 2.16

Fall back to the old behavior with older gtk.
Comment 2 Owen Taylor 2009-06-01 14:19:22 UTC
Well, this all really will take graphics design, but I'm fine with going with this conditionalization for now ... shows off a bunch of work I did anyways :-)

I think there does need to be a comment where the constants are defined explaining that they aren't always used.
Comment 3 Dan Winship 2009-06-02 14:37:01 UTC
committed
Comment 4 Milan Bouchet-Valat 2009-06-08 18:42:36 UTC
Here I'm getting gray rectangles from the top to the bottom of the bar with all GTK programs that have a tray icon. Using GTK+ 2.16.
Comment 5 Owen Taylor 2009-07-17 17:45:13 UTC
This was fixed, any system-specific or app-specific bugs should be filed separately.