GNOME Bugzilla – Bug 581780
CalDav and Web Calendar does not remember password on restart
Last modified: 2009-06-03 17:55:21 UTC
Please describe the problem: Evolution does not remember passwords for CalDav and Web Calendar on restart although the "remember password" box is checked. For Google calendars is works quite fine and it's not necessary to retype the password. Steps to reproduce: 1. add a new CalDav or Web Calendar with authentication required 2. check the "remember password" box 3. restart evolution Actual results: Evolution asks for the password again. Expected results: No password request on restart. Does this happen every time? yes Other information:
Thanks for the bug report. I guess you use keyring for your passwords, do you? The CalDAV should be fine since 2.26.2, though one more fix was necessary to let it work, see bug #578335 for more information. I see those "On The Web" don't work, confirming.
Created attachment 135333 [details] [review] proposed evo patch for evolution; I did this in quite similar way in CalDAV, though would be nice to have some review at least here. Thanks. Basically, keyring uses username from URL when reading/storing password, and webcal doesn't store usernames in URL, as didn't also CalDAV, after one my changes there, thus this adds username into URL.
*** Bug 509458 has been marked as a duplicate of this bug. ***
Instead of replace_at_sign function, you could use g_strdelimit glib function. Other than that it looks fine.
g_strdelimit changes list of bad characters to one character in a text, not to a string (I change '@' to "%40"), thus it's not the one :)
I tried to find if there is any function to do this common operation through glib. could not find any. Please commit the patch.
Created commit d83027f in evo master (2.27.3+) Created commit c045b51 in evo gnome-2-26. (2.26.3+)