GNOME Bugzilla – Bug 581249
Display embedded cover images in audio streams
Last modified: 2009-12-15 19:59:05 UTC
Audio streams can contain a cover image to use. Attached patch makes Totem use this as the album artwork for that stream. Reported in Ubuntu: https://bugs.launchpad.net/ubuntu/+source/totem/+bug/310610
Created attachment 133895 [details] [review] Uses cover image from audio streams
Tim, why wasn't that pushed upstream before? And do you have any examples of radio streams that use covers?
Hrm, I thought I had filed a bug with a patch for this (I didn't just commit it because I was under the impression you were not too keen on this for some reason, maybe we talked about it on IRC at some point?) Most of the BBC podcasts and many other podcasts contain an image IIRC, but the code as in the patch will probably show coverart for all streams, whether radio or local file. So ok to commit this then?
Looks fine to commit to master, minus the whitespace churn at the top of the file. Not sure how it would behave on streams (eg. internet radio) that would include cover art for different songs (or even adverts).
I currently can't build totem master because of the gtk+ requirement, so I'm probably not going to get around to committing this before I have time to upgrade. So maybe you want to commit this yourself.
Committed. Patch coming up to also display the cover image instead of visualisations when possible. commit d5877777c4e54f0cd403ef6e47f3d5c43711e5d7 Author: Robert Ancell <robert.ancell@gmail.com> Date: Sat Aug 8 19:28:59 2009 +0100 Bug 581249 – Display embedded cover images in audio streams Display cover images when available. Currently doesn't display cover images instead of visualisations. Helps: bgo#581249 src/backend/bacon-video-widget-gst-0.10.c | 83 ++++++++++++++++++++++------ 1 files changed, 65 insertions(+), 18 deletions(-)
That was my patch! ;-) (Sorry for dropping the ball on this. Thanks for committing it.)
Created attachment 140224 [details] [review] Display the cover image instead of visualisations This patch causes the cover image to also be displayed instead of visualisations, but depends on bug #583255.
(In reply to comment #7) > That was my patch! ;-) Sorry!