After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581120 - Null pointer crash in render_val
Null pointer crash in render_val
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: Graphing / Charting
unspecified
Other All
: Normal critical
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2009-05-02 18:18 UTC by sum1
Modified: 2009-05-02 20:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fixes the crash (536 bytes, patch)
2009-05-02 20:34 UTC, Jean Bréfort
committed Details | Review

Description sum1 2009-05-02 18:18:26 UTC
OS: Ubuntu Jaunty
Version: fe98f51f48e0be038317cb664730afb7ff4b3a16 (goffice)


Steps to reproduce:
- Download Attachment 17466 [details] (.xls file from Bug 114958)
- gnumeric 17466.xls


Console output:

GLib-GObject-WARNING **: IA__g_object_set_valist: invalid object type `GOStyle' for value type `GogStyle'
GLib-GObject-WARNING **: IA__g_object_set_valist: invalid object type `GOStyle' for value type `GogStyle'


Backtrace:

Program received signal SIGSEGV, Segmentation fault.

Thread 3065513744 (LWP 24778)

  • #0 render_val
    at graph.c line 88
  • #1 gnm_go_data_scalar_get_str
    at graph.c line 360
  • #2 go_data_scalar_get_str
    at go-data.c line 570
  • #3 _data_scalar_get_string
    at go-data.c line 538
  • #4 go_data_get_string
    at go-data.c line 470
  • #5 go_data_get_scalar_string
    at go-data.c line 476
  • #6 gog_series_dataset_set_dim
    at gog-series.c line 756
  • #7 gog_dataset_set_dim
    at gog-data-set.c line 115
  • #8 gog_series_set_dim
    at gog-series.c line 971
  • #9 XL_gog_series_set_dim
    at ms-chart.c line 2416
  • #10 xl_chart_read_end
    at ms-chart.c line 2916
  • #11 ms_excel_chart_read
    at ms-chart.c line 3569
  • #12 excel_read_BOF
    at ms-excel-read.c line 6575
  • #13 excel_read_workbook
    at ms-excel-read.c line 6653
  • #14 excel_file_open
    at boot.c line 192
  • #15 go_plugin_loader_module_func_file_open
    at go-plugin-loader-module.c line 239
  • #16 go_plugin_file_opener_open
    at go-plugin-service.c line 476
  • #17 go_file_opener_open
    at file.c line 299
  • #18 wb_view_new_from_input
    at workbook-view.c line 1057
  • #19 wb_view_new_from_uri
    at workbook-view.c line 1111
  • #20 main
    at main-application.c line 413

Comment 1 Jean Bréfort 2009-05-02 20:34:45 UTC
Created attachment 133828 [details] [review]
fixes the crash

There are tow things there: the style warning that I must fix, but which is not harmful, and a call to render_val with a NULL value (I checked this call occurs several times with expressions such as גיליון1!$D$1; at first the value is NULL, and the last time it is not).
Comment 2 Jean Bréfort 2009-05-02 20:56:50 UTC
Fixed.