After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581024 - Move streams to the new default sink
Move streams to the new default sink
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: gnome-volume-control
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-01 16:15 UTC by Bastien Nocera
Modified: 2009-05-15 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gvc-set-default-output-instant.patch (2.73 KB, patch)
2009-05-01 16:17 UTC, Bastien Nocera 		none Details | Review

Description Bastien Nocera 2009-05-01 16:15:57 UTC 
When changing the default sink, we should move all the streams to the new sink as well, otherwise it won't have an effect until we get to the next song/movie in most apps.
Comment 1 Bastien Nocera 2009-05-01 16:17:14 UTC 
Created attachment 133737 [details] [review]
gvc-set-default-output-instant.patch

Original bug at:
https://bugzilla.redhat.com/show_bug.cgi?id=489049
Comment 2 Marc-Andre Lureau 2009-05-03 16:43:47 UTC 
I would replace "const char *new_default_output" by a weak ref "GvcMixerStream *default_output", unless you have a reason to store the string, (and fix indent).

I guess the patch works, I didn't try it.

I don't think we need to bother about checking extension or bookkeeping operations.

If you agree on all that, I could update it.
Comment 3 Bastien Nocera 2009-05-03 17:20:57 UTC 
Sure, go for it. I'm still trying to do some other releases here...
Comment 4 Lennart Poettering 2009-05-05 14:48:09 UTC 
I'd suggest printing the error messages if things don work. i.e. include pa_strerror(pa_context_errno(c)) in the g_warning()s.

But otherwise the patch looks good to me!
Comment 5 Bastien Nocera 2009-05-15 13:06:38 UTC 
Committed to master with the changes mentioned above.

commit 97e1f672ce246ddbe339e20da7304a5f3ece1f00
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri May 15 14:01:52 2009 +0100

    Bug 581024 – Move streams to the new default sink
    
    Automatically move existing streams on the old sink to the new
    one. Makes choosing the default sink instant-apply.