After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579228 - brasero does not pass its testsuite
brasero does not pass its testsuite
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
2.26.1
Other Linux
: Normal normal
: 2.26
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-04-16 22:26 UTC by Gilles Dartiguelongue
Modified: 2009-06-01 14:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
check.log (9.13 KB, text/plain)
2009-04-16 22:26 UTC, Gilles Dartiguelongue 		  Details
Patch to fix broken sv/brasero.xml file (936 bytes, patch)
2009-05-16 19:47 UTC, Hans de Graaff 		rejected Details | Review
Patch to fix broken sv/brasero.xml file (807 bytes, patch)
2009-05-31 19:42 UTC, Hans de Graaff 		committed Details | Review

Description Gilles Dartiguelongue 2009-04-16 22:26:20 UTC 
Fails in help, will attach the result of the following command in a moment:

# LC_ALL="C" make check -k > ~/check.log
Comment 1 Gilles Dartiguelongue 2009-04-16 22:26:42 UTC 
Created attachment 132796 [details]
check.log
Comment 2 Luis Medinas 2009-05-06 22:11:12 UTC 
Confirmed, this is probably some mistake on translated help.
Comment 3 Hans de Graaff 2009-05-16 19:47:07 UTC 
Created attachment 134776 [details] [review]
Patch to fix broken sv/brasero.xml file

Here is a patch for the broken brasero.xml file.
Comment 4 Luis Medinas 2009-05-18 22:38:20 UTC 
Please commit to git master and gnome-2-26 branch.

Thanks for the patch.
Comment 5 Philippe Rouquier 2009-05-19 16:22:53 UTC 
I tried the patch and the problem is indeed in sv/brasero.xml but sv/brasero.xml is generated at build time and is not a file that is git tracked.
I think the patch should be made against the sv.po in the help/sv/ directory since help/sv/brasero.xml is generated from this file as far as I understand it.
Comment 6 Luis Medinas 2009-05-19 18:27:52 UTC 
Per Philippe comments. Please regen your patch according.
Comment 7 Hans de Graaff 2009-05-31 19:42:59 UTC 
Created attachment 135686 [details] [review]
Patch to fix broken sv/brasero.xml file

This new version of the patch patches the sv.po file instead.
Comment 8 Philippe Rouquier 2009-06-01 14:04:06 UTC 
Thanks for the patch Hans, It's committed to both trunk and 2.26 branch.