GNOME Bugzilla – Bug 579031
[PATCH] epiphany-2.26.1 libcanberra automagic support fixed
Last modified: 2011-07-30 05:40:53 UTC
Please describe the problem: Hi, libcanberra support was automagic in the configure script, i written a small patch to solve the problem. This patch only updates the configure.ac, by adding a call to AC_ARG_ENABLE m4 macro, and ONLY if the support was explicitely required and if support was found on the system, including libcanberra support. this upstream refers to the bug https://bugs.gentoo.org/show_bug.cgi?id=266232 mrpouet ;) Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 132683 [details] [review] the patch which solves the problem
+AC_ARG_ENABLE([canberra], + AC_HELP_STRING([--enable-canberra], + [Enable canberra support @<:@default=yes@:>@]), + enable_canberra=$enableval, enable_canberra=yes) Should be like this: AC_ARG_ENABLE([canberra],[AS_HELP_STRING(...)],[],[enable_canberra=yes]) +have_libcanberra_gtk=no Not necessary. +if test "$enable_canberra" = "yes"; then + PKG_CHECK_EXISTS([libcanberra-gtk >= $LIBCANBERRA_GTK_REQUIRED],[have_libcanberra_gtk=yes], + [have_libcanberra_gtk=no]) Do it like this: PKG_CHECK_EXISTS([....],[],[AC_MSG_ERROR([canberra not found])]) and then you can lose the if have_... check below. + if test "$have_libcanberra_gtk" = "yes"; then + LIBCANBERRA_GTK_PACKAGE="libcanberra-gtk >= $LIBCANBERRA_GTK_REQUIRED" + AC_DEFINE([HAVE_LIBCANBERRA_GTK],[1],[Define if libcanberra-gtk is available]) + fi + Canberra support : $have_libcanberra_gtk Use $enable_canberra here.
Don't use canberra anymore!