After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578672 - remember size, position and state of undocked tabs windows
remember size, position and state of undocked tabs windows
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal major
: 0.91
Assigned To: Jean-François Fortin Tam
Pitivi maintainers
: 667804 (view as bug list)
Depends on:
Blocks: 643392
 
 
Reported: 2009-04-10 23:19 UTC by Jean-François Fortin Tam
Modified: 2012-11-08 21:59 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2009-04-10 23:19:38 UTC
When undocking parts of the ui, such as the media library, re-docking them will reset their position, width and height. Furthermore, closing pitivi will reset them to the "docked" state.

The reason I'm marking it as major is that without these things, being able to undock stuff from the GUI is useless.
Comment 1 Brandon Lewis 2009-07-28 19:14:12 UTC
maybe we should remove this feature?
Comment 2 antistress 2009-07-29 23:13:55 UTC
if PiTiVi is going to remember size, position and state of undocked windows, it should also offer a "reset the GUI" function
If a beginner accidentally changes the GUI he may like having a "forgive me" function
Comment 3 Jean-François Fortin Tam 2009-07-29 23:19:29 UTC
Wouldn't docking the things again act as a reset for that particular component? Could be a way to do it simply.
Comment 4 antistress 2009-07-29 23:57:37 UTC
indeed, my c#2 was confused

Concerning c#1 from Brandon Lewis, i think that feature can be useful for normal/small screens : undocking the source list gives more space for the previewer (besides, with GIMP, people are used to deal with several windows).
Not to mention people with several screens.

If you decide to create other tabs like the "Effects library" (that can be seen here http://www.pitivi.org/wiki/UI_Design_Variants ), both tabs should be considered like a single undocking object
Comment 5 Alessandro Decina 2009-09-02 14:09:06 UTC
I have mixed feelings about undockable widgets. I understand the general idea, but at the moment the sourcelist is the only undockable element we have. If you undock it, it doesn't really free any space on the main window though, since the viewer will keep the aspect ratio.
Comment 6 Jean-François Fortin Tam 2010-09-09 20:56:15 UTC
This will make more sense with the various new panes from the special effects branch, or for those using multihead setups.
Comment 7 Jean-François Fortin Tam 2012-10-24 19:49:16 UTC
*** Bug 667804 has been marked as a duplicate of this bug. ***
Comment 8 Jean-François Fortin Tam 2012-11-08 04:55:53 UTC
I picked up and reworked my two-years-old branch that aims to solve this. It is now ready and I'd need someone to review it: https://github.com/nekohayo/pitivi/commits/bug-578672-redux
Comment 9 Jean-François Fortin Tam 2012-11-08 21:59:47 UTC
commit b0617eac114b1f8dbd26d56750a1e1d4edb1ebc3
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Wed Nov 7 23:27:51 2012 -0500

    tabsmanager: Restore the state of undocked utility windows on startup

commit 03596cc078fc585bfaf1676592a6e1a20f17e1b1
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Wed Nov 7 23:27:17 2012 -0500

    settings: Return values of the proper type in readSettingSectionFromFile

commit 16e968189e05b8ddfd1bc5f68c5db750adf6817b
Author: Luis de Bethencourt <luis.debethencourt@collabora.com>
Date:   Wed Nov 7 18:51:04 2012 -0500

    settings: Iterate over section keys instead of invoking each one manually

commit d09fb109e842f2bcbca6a47cc6deb2c630bacfac
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Wed Nov 7 18:14:44 2012 -0500

    settings.py: Document the new method for force-reading key sections

commit 451dd755b98f2599b079febe0db51d887c4d3f6c
Author: Luis de Bethencourt <luis.debethencourt@collabora.com>
Date:   Wed Nov 7 17:47:16 2012 -0500

    Allow reading values from settings config file at runtime

commit a4c367431d3ced3f741f293f90c8d8228cea0c10
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Tue Nov 6 12:06:24 2012 -0500

    tabsmanager: Save/restore settings from detached tabs
    
    For some reason, everything resets to defaults on startup.
    
    First steps towards fixing bug #578672

commit 4b685fb56a675286ddb0f5f492815908ed8c2bc8
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Tue Nov 6 12:02:29 2012 -0500

    tabsmanager: Split _createWindowCb into a separate method

commit 3a8f91082508aef3696951b6e8d7c5c633f18d40
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Tue Nov 6 11:54:17 2012 -0500

    tabsmanager: Add initial code for creating/saving default settings for each tab