After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578148 - Respawn Compiz when gnome-shell ends
Respawn Compiz when gnome-shell ends
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-04-06 15:34 UTC by Siegfried Gevatter (RainCT)
Modified: 2009-04-07 00:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Respawn Compiz if it was running (1.85 KB, patch)
2009-04-06 15:35 UTC, Siegfried Gevatter (RainCT) 		needs-work Details | Review
Fixed info messages to be more exact (2.02 KB, patch)
2009-04-06 16:43 UTC, Siegfried Gevatter (RainCT) 		accepted-commit_now Details | Review

Description Siegfried Gevatter (RainCT) 2009-04-06 15:34:38 UTC 
GNOME Shell should respawn Compiz instead of Metacity if the first one is what was running before.
Comment 1 Siegfried Gevatter (RainCT) 2009-04-06 15:35:03 UTC 
Created attachment 132196 [details] [review]
Respawn Compiz if it was running
Comment 2 Dan Winship 2009-04-06 15:45:34 UTC 
this mostly looks good. however:

-    if not run_in_xephyr and (metacity_pid or gnome_panel_pid):
+    if not run_in_xephyr:
         # Restart gnome-panel and window manager
         if options.verbose:
-            print "Restarting Metacity and Gnome Panel"
+            print "Restarting window manager and gnome-panel"

It shouldn't print that message if it's not going to be re-starting anything, which would happen if you started gnome-shell at the start of the session rather than starting metacity/compiz and gnome-panel first and then replacing them later. Probably we should just have separate "Restarting metacity", "Restarting compiz" and "Restarting gnome-panel" messages, inside the three if's below that.
Comment 3 Siegfried Gevatter (RainCT) 2009-04-06 16:43:45 UTC 
Created attachment 132199 [details] [review]
Fixed info messages to be more exact
Comment 4 Dan Winship 2009-04-06 19:20:25 UTC 
Sure, looks good. (Do you have git access or should I commit it?)
Comment 5 Siegfried Gevatter (RainCT) 2009-04-06 19:30:40 UTC 
I haven't, please commit :).
Comment 6 Dan Winship 2009-04-07 00:38:11 UTC 
committed. thanks for the patch