After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577774 - Test suite run even when built with --disable-gtk-doc
Test suite run even when built with --disable-gtk-doc
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.11
Other Linux
: Normal normal
: 1.12
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-02 20:43 UTC by Gilles Dartiguelongue
Modified: 2009-09-28 15:08 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
build.log.gz (7.97 KB, application/x-gzip)
2009-04-04 20:18 UTC, Gilles Dartiguelongue
  Details
Patch based on SVN version of examples/Makefile.am (332 bytes, patch)
2009-08-20 04:43 UTC, Philip Chimento
none Details | Review

Description Gilles Dartiguelongue 2009-04-02 20:43:02 UTC
Using gtk-doc-1.11

./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64
[snip]
make[1]: quittant le répertoire « /var/tmp/portage/dev-libs/totem-pl-parser-2.26.1/work/totem-pl-parser-2.26.1/po »
Making check in docs
make[1]: entrant dans le répertoire « /var/tmp/portage/dev-libs/totem-pl-parser-2.26.1/work/totem-pl-parser-2.26.1/docs »
Making check in reference
make[2]: entrant dans le répertoire « /var/tmp/portage/dev-libs/totem-pl-parser-2.26.1/work/totem-pl-parser-2.26.1/docs/reference »
make  check-TESTS
make[3]: entrant dans le répertoire « /var/tmp/portage/dev-libs/totem-pl-parser-2.26.1/work/totem-pl-parser-2.26.1/docs/reference »
Running suite(s): gtk-doc-totem-pl-parser
Cannot open totem-pl-parser-undocumented.txt: Aucun fichier ou dossier de ce type
FAIL: /usr/bin/gtkdoc-check
==================================================================================================
1 of 1 tests failed
Please report to http://bugzilla.gnome.org/enter_bug.cgi?product=totem-pl-parser&component=General
==================================================================================================
make[3]: *** [check-TESTS] Erreur 1
make[3]: quittant le répertoire « /var/tmp/portage/dev-libs/totem-pl-parser-2.26.1/work/totem-pl-parser-2.26.1/docs/reference »
make[2]: *** [check-am] Erreur 2
make[2]: quittant le répertoire « /var/tmp/portage/dev-libs/totem-pl-parser-2.26.1/work/totem-pl-parser-2.26.1/docs/reference »
make[1]: *** [check-recursive] Erreur 1
make[1]: quittant le répertoire « /var/tmp/portage/dev-libs/totem-pl-parser-2.26.1/work/totem-pl-parser-2.26.1/docs »
make: *** [check-recursive] Erreur 1


I pass post full build.log if necessary.
Comment 1 Philip Withnall 2009-04-04 19:43:00 UTC
Interestingly, the gtk-doc checks pass for me, but the parser tests fail.

Could you add the full build.log as an attachment please?
Comment 2 Gilles Dartiguelongue 2009-04-04 20:15:33 UTC
Just got this with totem as well. It looks like both package don't include $(PACKAGE_NAME)-undocument.txt which means that passing --disable-gtk-doc when building the package will lead to failures when testing.

I verified this by rm *.txt in docs/references, svn up to check I didn't destroy anything that was versionned and repeating this operation when changing configure options.
Comment 3 Gilles Dartiguelongue 2009-04-04 20:18:38 UTC
Created attachment 132099 [details]
build.log.gz

full build.log. I guess this is more of a gtk-doc bug since it should include this file in the tarball for people installing pre-generated documentation.
Comment 4 Philip Withnall 2009-04-04 22:53:52 UTC
This is a gtk-doc bug, very similar to bug #546836 and bug #546138, but the problem is probably more that gtk-doc is running its test suite even when the package is built with --disable-gtk-doc.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2009-04-05 17:58:29 UTC
Its not really a gtk-doc bug. In your Makefile.am you would need to make enabling the test conditional. I have improved the makefile template accordingly.

# Comment this out if you want your docs-status tested during 'make check'
if ENABLE_GTK_DOC
#TESTS_ENVIRONMENT = cd $(srcsrc)
#TESTS = $(GTKDOC_CHECK)
endif
Comment 6 Philip Chimento 2009-08-20 04:43:28 UTC
Created attachment 141210 [details] [review]
Patch based on SVN version of examples/Makefile.am
Comment 7 Philip Chimento 2009-08-20 04:44:54 UTC
That snippet in comment #5 breaks distcheck when those two lines are uncommented, at least for me. Here's one that does work:

if ENABLE_GTK_DOC
TESTS_ENVIRONMENT = cd $(srcdir) &&
TESTS = $(GTKDOC_CHECK)
endif

I've attached a patch based on the SVN version of examples/Makefile.am.
Comment 8 Stefan Sauer (gstreamer, gtkdoc dev) 2009-09-28 15:08:22 UTC
commit d8ccc4d71805d5c10927615e83e94c3b380cc780
Author: Philip Chimento <philip.chimento@gmail.com>
Date:   Mon Sep 28 18:04:39 2009 +0300

    examples: fix makefile for running tests. Fixes #577774
    
    Add a '&&' to test-env variable.